Re: [PATCH] 3/3: MCA/MCE correctable error handling

["Christoph Egger" <Christoph.Egger@amd.com>]

On Tuesday 21 August 2007 18:02:54 Jan Beulich wrote:
> >+		if (mc_global->mc_flags & MC_FLAG_UNCORRECTABLE)
> >+			printk(KERN_EMERG);
> >+		else
> >+			printk(KERN_INFO);
>
> KERN_INFO seems gross understatement here - generally, correctable MCs are
> considered indicators that within not too distant future uncorrectable MCs
> might result, so this generally is a call for action (and hence shouldn't
> be hidden with default log level settings).

Well, that is what the "old" code did. It used KERN_EMERG for fatal errors
and KERN_INFO in the polling service routine. What do you want me to suggest?

> Also, I'm not sure adjusting the polling frequency makes much sense - 30s
> seems an awful lot of time to me.

It's not clear to me what you are trying to tell me. Please explain/elaborate.


Christoph


-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy