All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: Gavin.Maltby@sun.com, xen-devel@lists.xensource.com,
	Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] 3/3: MCA/MCE correctable error handling
Date: Tue, 21 Aug 2007 17:02:54 +0100	[thread overview]
Message-ID: <46CB28CE.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200708211531.44997.Christoph.Egger@amd.com>

>+		if (mc_global->mc_flags & MC_FLAG_UNCORRECTABLE)
>+			printk(KERN_EMERG);
>+		else
>+			printk(KERN_INFO);

KERN_INFO seems gross understatement here - generally, correctable MCs are
considered indicators that within not too distant future uncorrectable MCs might
result, so this generally is a call for action (and hence shouldn't be hidden with
default log level settings).

Also, I'm not sure adjusting the polling frequency makes much sense - 30s seems
an awful lot of time to me.

Jan

  reply	other threads:[~2007-08-21 16:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21 13:31 [PATCH] 3/3: MCA/MCE correctable error handling Christoph Egger
2007-08-21 16:02 ` Jan Beulich [this message]
2007-08-22  9:00   ` Christoph Egger
2007-08-22 10:09     ` Jan Beulich
2007-08-22 15:56       ` Christoph Egger
2007-08-22 16:05         ` Keir Fraser
2007-08-22 16:10           ` Keir Fraser
2007-08-23  6:57             ` Christoph Egger
2007-08-23  9:27               ` [PATCH] resend " Christoph Egger
2007-08-23 14:07               ` [PATCH] " Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CB28CE.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Christoph.Egger@amd.com \
    --cc=Gavin.Maltby@sun.com \
    --cc=keir@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.