All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] sched: fix broken smt/mc optimizations with CFS
@ 2007-08-16  1:01 Siddha, Suresh B
  2007-08-23 10:38 ` Ingo Molnar
  2007-08-23 11:54 ` Ingo Molnar
  0 siblings, 2 replies; 14+ messages in thread
From: Siddha, Suresh B @ 2007-08-16  1:01 UTC (permalink / raw)
  To: mingo; +Cc: nickpiggin, linux-kernel, akpm

Ingo, let me know if there any side effects of this change. Thanks.
---

On a four package system with HT - HT load balancing optimizations
were broken. For example, if two tasks end up running on two logical
threads of one of the packages, scheduler is not able to pull one of
the tasks to a completely idle package.

In this scenario, for nice-0 tasks, imbalance calculated by scheduler
will be 512 and find_busiest_queue() will return 0 (as each cpu's load
is 1024 > imbalance and has only one task running).

Similarly MC scheduler optimizations also get fixed with this patch.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

diff --git a/kernel/sched.c b/kernel/sched.c
index 45e17b8..c5ac710 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2494,7 +2494,7 @@ group_next:
 	 * a think about bumping its value to force at least one task to be
 	 * moved
 	 */
-	if (*imbalance + SCHED_LOAD_SCALE_FUZZ < busiest_load_per_task/2) {
+	if (*imbalance < busiest_load_per_task) {
 		unsigned long tmp, pwr_now, pwr_move;
 		unsigned int imbn;
 

^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2007-09-05 10:51 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-16  1:01 [patch] sched: fix broken smt/mc optimizations with CFS Siddha, Suresh B
2007-08-23 10:38 ` Ingo Molnar
2007-08-23 11:54 ` Ingo Molnar
2007-08-23 12:13   ` Ingo Molnar
2007-08-23 17:42     ` Daniel Walker
2007-08-27 19:19     ` Siddha, Suresh B
2007-08-27 19:23       ` Ingo Molnar
2007-08-27 19:31         ` Siddha, Suresh B
2007-08-28 22:27           ` Siddha, Suresh B
2007-08-29  3:42             ` Ingo Molnar
2007-09-04 23:35             ` Chuck Ebbert
2007-09-04 23:46               ` Siddha, Suresh B
2007-09-05 10:51                 ` Ingo Molnar
2007-08-27 16:32   ` Torsten Kaiser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.