All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [uml-devel] [PATCH] UML - time build fix
Date: Tue, 25 Sep 2007 17:56:29 -0400	[thread overview]
Message-ID: <20070925215629.GA10926@c2.user-mode-linux.org> (raw)
In-Reply-To: <1190750055.17409.38.camel@chaos>

On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote:
> On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote:
> > Put back an implementation of timeval_to_ns in
> > arch/um/os-Linux/time.c.  tglx pointed out in his review of tickless
> > support that there was a perfectly good implementation of it in
> > linux/time.h.  The problem is that this is userspace code which can't
> > pull in kernel headers and there doesn't seem to be a libc version.
> 
> Oops. Did not notice. 

It's a UML peculiarity...

> Can't we move it into some header file which is accessible from everywhere ?

Not in the generic kernel.  UML has some generally includable headers
of its own, but that doesn't really help.

The one thing that would help is a libc timeval_to_ns.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH] UML - time build fix
Date: Tue, 25 Sep 2007 17:56:29 -0400	[thread overview]
Message-ID: <20070925215629.GA10926@c2.user-mode-linux.org> (raw)
In-Reply-To: <1190750055.17409.38.camel@chaos>

On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote:
> On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote:
> > Put back an implementation of timeval_to_ns in
> > arch/um/os-Linux/time.c.  tglx pointed out in his review of tickless
> > support that there was a perfectly good implementation of it in
> > linux/time.h.  The problem is that this is userspace code which can't
> > pull in kernel headers and there doesn't seem to be a libc version.
> 
> Oops. Did not notice. 

It's a UML peculiarity...

> Can't we move it into some header file which is accessible from everywhere ?

Not in the generic kernel.  UML has some generally includable headers
of its own, but that doesn't really help.

The one thing that would help is a libc timeval_to_ns.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

  reply	other threads:[~2007-09-25 21:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 17:37 [uml-devel] [PATCH] UML - time build fix Jeff Dike
2007-09-25 17:37 ` Jeff Dike
2007-09-25 19:54 ` [uml-devel] " Thomas Gleixner
2007-09-25 19:54   ` Thomas Gleixner
2007-09-25 21:56   ` Jeff Dike [this message]
2007-09-25 21:56     ` Jeff Dike
2007-09-25 22:08     ` [uml-devel] " Thomas Gleixner
2007-09-25 22:08       ` Thomas Gleixner
2007-09-26 15:46       ` [uml-devel] " Paolo Giarrusso
2007-09-26 15:46         ` Paolo Giarrusso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070925215629.GA10926@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.