[patch 1/1] scsi: fix a few misleading comments in scsi.c

[patch 1/1] scsi: fix a few misleading comments in scsi.c

[scameron]

Fix a few misleading comments in scsi.c

Signed-off-by: Stephen M. Cameron <steve.cameron@hp.com>

---


diff -puN linux-2.6.24-rc1/drivers/scsi/scsi.c~fix_scsi_comments linux-2.6.24-rc1/drivers/scsi/scsi.c
--- dynamic_scsi/linux-2.6.24-rc1/drivers/scsi/scsi.c~fix_scsi_comments	2007-10-25 08:52:01.000000000 -0400
+++ dynamic_scsi-root/linux-2.6.24-rc1/drivers/scsi/scsi.c	2007-10-25 08:53:45.000000000 -0400
@@ -897,7 +897,7 @@ EXPORT_SYMBOL(__scsi_iterate_devices);
  * @starget:	target whose devices we want to iterate over.
  *
  * This traverses over each devices of @shost.  The devices have
- * a reference that must be released by scsi_host_put when breaking
+ * a reference that must be released by scsi_device_put when breaking
  * out of the loop.
  */
 void starget_for_each_device(struct scsi_target *starget, void * data,
@@ -949,7 +949,7 @@ EXPORT_SYMBOL(__scsi_device_lookup_by_ta
  *
  * Looks up the scsi_device with the specified @channel, @id, @lun for a
  * give host.  The returned scsi_device has an additional reference that
- * needs to be release with scsi_host_put once you're done with it.
+ * needs to be release with scsi_device_put once you're done with it.
  **/
 struct scsi_device *scsi_device_lookup_by_target(struct scsi_target *starget,
 						 uint lun)
@@ -1008,7 +1008,7 @@ EXPORT_SYMBOL(__scsi_device_lookup);
  *
  * Looks up the scsi_device with the specified @channel, @id, @lun for a
  * give host.  The returned scsi_device has an additional reference that
- * needs to be release with scsi_host_put once you're done with it.
+ * needs to be release with scsi_device_put once you're done with it.
  **/
 struct scsi_device *scsi_device_lookup(struct Scsi_Host *shost,
 		uint channel, uint id, uint lun)
_

Re: [patch 1/1] scsi: fix a few misleading comments in scsi.c

[Matthew Wilcox]

On Fri, Oct 26, 2007 at 08:42:17AM -0500, scameron@beardog.cca.cpqcorp.net wrote:
> - * needs to be release with scsi_host_put once you're done with it.
> + * needs to be release with scsi_device_put once you're done with it.

s/release/released/ as well?

> - * needs to be release with scsi_host_put once you're done with it.
> + * needs to be release with scsi_device_put once you're done with it.

ditto

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [patch 1/1] scsi: fix a few misleading comments in scsi.c

[Stefan Richter]

> On Fri, Oct 26, 2007 at 08:42:17AM -0500, scameron@beardog.cca.cpqcorp.net wrote:
>> - * needs to be release with scsi_host_put once you're done with it.
>> + * needs to be release with scsi_device_put once you're done with it.

Well, hopefully this fix goes finally in now. :-)
http://marc.info/?l=linux-scsi&m=114279682717770
-- 
Stefan Richter
-=====-=-=== =-=- ==-=-
http://arcgraph.de/sr/