Re: [PATCH] gdth: scp timeout clean up

[malahal@us.ibm.com]

Boaz Harrosh [bharrosh@panasas.com] wrote:
> > +static enum scsi_eh_timer_return gdth_timed_out(struct scsi_cmnd *scp)
> > +{
> > +	gdth_ha_str *ha = shost_priv(scp->device->host);
> > +	struct gdth_cmndinfo *cmndinfo = gdth_get_cmndinfo(ha);
> 
> a gdth_get_cmndinfo(ha) is for allocating a new cmndinfo out of free
> cmndinfo list, and must be paired by a call to gdth_put_cmndinfo(ha).
> And usually you want to put it on scp->host_scribble, other wise it will
> be lost. 
> To get the cmndinfo associated with a scsi_cmnd use gdth_cmnd_priv(scp) 

Thank you very much. It should be gdth_cmnd_priv(scp). I will fix it.