All of lore.kernel.org
 help / color / mirror / Atom feed
From: malahal@us.ibm.com
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-scsi@vger.kernel.org, andmike@us.ibm.com
Subject: Re: [PATCH] blk request timeout minor fixes...
Date: Wed, 5 Dec 2007 12:40:03 -0800	[thread overview]
Message-ID: <20071205204003.GA29267@us.ibm.com> (raw)
In-Reply-To: <20071205201038.GE29561@kernel.dk>

Jens Axboe [jens.axboe@oracle.com] wrote:
> ->timeout isn't used very much, so should not be too much work to
> console the two.
> 
> If you see any specific obstacles, do list them!

I believe it is used in blk_add_timer() which may be called:
1) First time sending the command to LLDs
   No problem. It would be set to correct value at that time.
2) called from blk_rq_timed_out() in response to BLK_EH_RESET_TIMER
   Without the actual timeout value, there is no way to res-set timer
   correctly.
3) Retry
   Same #2.

The other way is to remove the deadline field. That poses timing out
issues.

Thanks, Malahal.

  reply	other threads:[~2007-12-05 20:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06  6:54 [PATCH] gdth: scp timeout clean up malahal
2007-11-06  7:54 ` Boaz Harrosh
2007-11-06 16:18   ` malahal
2007-11-06 22:34   ` [PATCH] gdth: scp timeout clean up (try #2) malahal
2007-11-07 13:22     ` Jens Axboe
2007-11-14  2:39       ` malahal
2007-12-03  1:53         ` [PATCH] blk request timeout minor fixes malahal
2007-12-03  2:49           ` Matthew Wilcox
2007-12-03 23:47             ` malahal
2007-12-04  9:00               ` Jens Axboe
2007-12-05 20:05                 ` malahal
2007-12-05 20:10                   ` Jens Axboe
2007-12-05 20:40                     ` malahal [this message]
2007-12-05 21:06       ` Another use for block-layer timeouts Matthew Wilcox
2007-11-07 17:35     ` [PATCH] gdth: scp timeout clean up (try #2) Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071205204003.GA29267@us.ibm.com \
    --to=malahal@us.ibm.com \
    --cc=andmike@us.ibm.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.