From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix serial console on LinuxBIOS
Date: Fri, 9 Nov 2007 22:34:01 +0100 [thread overview]
Message-ID: <20071109213401.GG23437@thorin> (raw)
In-Reply-To: <87640bl9ln.fsf@xs4all.nl>
On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
>
> > This patch fixes serial console on LinuxBIOS.
> >
> > I'd appreciate comments (specially on the <grub/machine/machine.h> addition).
> >
> > --
> > Robert Millan
> >
> > <GPLv2> I know my rights; I want my phone call!
> > <DRM> What use is a phone call, if you are unable to speak?
> > (as seen on /.)
> >
>
> No header ;)
Uhm what header?
> > * include/grub/i386/efi/machine.h: New file.
> > * include/grub/i386/linuxbios/machine.h: Likewise.
> > * include/grub/i386/pc/machine.h: Likewise.
> > * include/grub/powerpc/ieee1275/machine.h: Likewise.
> > * include/grub/sparc64/ieee1275/machine.h: Likewise.
> >
> > * term/i386/pc/serial.c: Include <grub/machine/machine.h>.
> > (serial_hw_io_addr): New variable.
> > (serial_hw_get_port): Obtain port address from `serial_hw_io_addr'
> > instead of `(unsigned short *) 0x400'.
>
> This seems fine to me. What is your intended use for machine.h? More
> than just this?
Situations very similar to this one, in that you just need to change a few
unportable lines while the overall structure of the file remains portable.
> Perhaps we can even use autoconf to define this in config.h? That
> would be better I think.
autoconf already setups the cpu / machine symlinks. Why ask it to tell the
same info twice?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2007-11-09 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 20:53 [PATCH] fix serial console on LinuxBIOS Robert Millan
2007-11-08 2:02 ` Jerone Young
2007-11-08 21:30 ` Robert Millan
2007-11-09 15:30 ` Marco Gerards
2007-11-09 21:34 ` Robert Millan [this message]
2007-11-10 15:29 ` Marco Gerards
2007-11-10 20:25 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109213401.GG23437@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.