Re: [PATCH] fix serial console on LinuxBIOS

[Marco Gerards <mgerards@xs4all.nl>]

Robert Millan <rmh@aybabtu.com> writes:

> On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote:
>> Robert Millan <rmh@aybabtu.com> writes:
>> 
>> > This patch fixes serial console on LinuxBIOS.
>> >
>> > I'd appreciate comments (specially on the <grub/machine/machine.h> addition).
>> >
>> > -- 
>> > Robert Millan
>> >
>> > <GPLv2> I know my rights; I want my phone call!
>> > <DRM> What use is a phone call, if you are unable to speak?
>> > (as seen on /.)
>> >
>> 
>> No header ;)
>
> Uhm what header?

That's what I said ;-)

What I meant was something like:

2007-10-31  Robert Millan  <rmh@aybabtu.com>

>> > 	* include/grub/i386/efi/machine.h: New file.
>> > 	* include/grub/i386/linuxbios/machine.h: Likewise.
>> > 	* include/grub/i386/pc/machine.h: Likewise.
>> > 	* include/grub/powerpc/ieee1275/machine.h: Likewise.
>> > 	* include/grub/sparc64/ieee1275/machine.h: Likewise.
>> >
>> > 	* term/i386/pc/serial.c: Include <grub/machine/machine.h>.
>> > 	(serial_hw_io_addr): New variable.
>> > 	(serial_hw_get_port): Obtain port address from `serial_hw_io_addr'
>> > 	instead of `(unsigned short *) 0x400'.
>> 
>> This seems fine to me.  What is your intended use for machine.h?  More
>> than just this?
>
> Situations very similar to this one, in that you just need to change a few
> unportable lines while the overall structure of the file remains portable.

What I meant was: what should and shouldn't be added to this .h?

>> Perhaps we can even use autoconf to define this in config.h?  That
>> would be better I think.
>
> autoconf already setups the cpu / machine symlinks.  Why ask it to tell the
> same info twice?

Isn't that what you are doing now?  But I have no objections to this
fix, please commit it :-)

--
Marco