All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Amit Shah <amit.shah@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH 4/8] KVM: PVDMA: Introduce is_pv_device() dma operation
Date: Mon, 12 Nov 2007 12:52:01 +0200	[thread overview]
Message-ID: <20071112105201.GG3299@rhun.haifa.ibm.com> (raw)
In-Reply-To: <218cf425feff1d4daf23d3f25df1eb224108a1a3.1194445109.git.amit.shah@qumranet.com>

On Wed, Nov 07, 2007 at 04:21:05PM +0200, Amit Shah wrote:

> A guest can call dma_ops->is_pv_device() to find out if a device is
> a passthrough'ed device (device passed on to a guest by the
> host). If this is true, a hypercall will be made to translate DMA
> mapping operations.

Doesn't really belong in the DMA mapping API. Instead what I think we
should do is to cache this (per device) value in the pci_device struct
(or device struct?) and in the dma-ops implementation inspect it to
decide exactly how to do DMA mapping for this device.

Cheers,
Muli

WARNING: multiple messages have this Message-ID (diff)
From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: Amit Shah <amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/8] KVM: PVDMA: Introduce is_pv_device() dma operation
Date: Mon, 12 Nov 2007 12:52:01 +0200	[thread overview]
Message-ID: <20071112105201.GG3299@rhun.haifa.ibm.com> (raw)
In-Reply-To: <218cf425feff1d4daf23d3f25df1eb224108a1a3.1194445109.git.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

On Wed, Nov 07, 2007 at 04:21:05PM +0200, Amit Shah wrote:

> A guest can call dma_ops->is_pv_device() to find out if a device is
> a passthrough'ed device (device passed on to a guest by the
> host). If this is true, a hypercall will be made to translate DMA
> mapping operations.

Doesn't really belong in the DMA mapping API. Instead what I think we
should do is to cache this (per device) value in the pci_device struct
(or device struct?) and in the dma-ops implementation inspect it to
decide exactly how to do DMA mapping for this device.

Cheers,
Muli

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-11-12 10:52 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 14:21 RFC: Paravirtualized DMA accesses for KVM Amit Shah
2007-11-07 14:21 ` Amit Shah
2007-11-07 14:21 ` [PATCH 1/8] KVM: PVDMA Host: Handle reqeusts for guest DMA mappings Amit Shah
2007-11-07 14:21   ` Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21   ` [PATCH 2/8] KVM: Move #include asm/kvm_para.h outside of __KERNEL__ Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-07 14:21   ` [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-12 10:50     ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 10:50       ` Muli Ben-Yehuda
2007-11-12 11:56       ` [kvm-devel] " Amit Shah
2007-11-12 11:56         ` Amit Shah
2007-11-12 13:32         ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 13:32           ` Muli Ben-Yehuda
2007-11-12 13:55           ` [kvm-devel] " Amit Shah
2007-11-12 13:55             ` Amit Shah
2007-11-12 14:01             ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 14:01               ` Muli Ben-Yehuda
2007-11-12 14:53       ` [kvm-devel] " Gerd Hoffmann
2007-11-12 14:53         ` Gerd Hoffmann
2007-11-12 16:00       ` [kvm-devel] " Joerg Roedel
2007-11-12 16:00         ` Joerg Roedel
2007-11-07 14:21   ` [PATCH 4/8] KVM: PVDMA: Introduce is_pv_device() dma operation Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-12 10:52     ` Muli Ben-Yehuda [this message]
2007-11-12 10:52       ` Muli Ben-Yehuda
2007-11-07 14:21   ` [PATCH 5/8] KVM: PVDMA: Update dma_alloc_coherent to make it paravirt-aware Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-12 10:56     ` [kvm-devel] " Muli Ben-Yehuda
2007-11-12 10:56       ` Muli Ben-Yehuda
2007-11-12 11:59       ` [kvm-devel] " Amit Shah
2007-11-12 11:59         ` Amit Shah
2007-11-07 14:21   ` [PATCH 6/8] KVM: PVDMA Guest: Add Makefile rule Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-07 14:21   ` [PATCH 7/8] PVDMA: Guest: Add Kconfig options to select PVDMA Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-07 14:21   ` [PATCH 8/8] KVM: Update drivers/Makefile to check for CONFIG_VIRTUALIZATION Amit Shah
2007-11-07 14:21     ` Amit Shah
2007-11-07 14:21       ` Amit Shah
2007-11-12 15:55   ` [kvm-devel] [PATCH 1/8] KVM: PVDMA Host: Handle reqeusts for guest DMA mappings Joerg Roedel
2007-11-12 15:55     ` Joerg Roedel
2007-11-12 17:07     ` [kvm-devel] " Amit Shah
2007-11-12 17:07       ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071112105201.GG3299@rhun.haifa.ibm.com \
    --to=muli@il.ibm.com \
    --cc=amit.shah@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.