All of lore.kernel.org
 help / color / mirror / Atom feed
* 2.6.24-rc1: OOPS at  acpi_battery_update
@ 2007-10-29 10:11 ` Romano Giannetti
  0 siblings, 0 replies; 25+ messages in thread
From: Romano Giannetti @ 2007-10-29 10:11 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-acpi


Hi,

	sometime on resuming from s2ram my laptop spew the following oops.
Config, dmesg etc are at: 

http://www.dea.icai.upcomillas.es/romano/linux/info/2624rc1_6/

[    3.475386] Oops: 0000 [#1] SMP 
[    3.475602] Process kacpi_notify (pid: 50, ti=c2122000 task=c210c030 task.ti=c2122000)
[    3.475608] Stack: c35c5060 c02f2a58 00000046 00000000 6b6b6b6b c2b20298 c2123efc c02f29ac 
[    3.475626]        c02166cb f896f3ca 00000000 f896ff63 00000246 00000000 c2b20298 ffffa512 
[    3.475644]        c2123f04 c02f2a58 c2123f34 f896f3ed c2123f1c c34fbdb8 c2123f20 c02f3e22 
[    3.475662] Call Trace:
[    3.475667]  [show_trace_log_lvl+26/48] show_trace_log_lvl+0x1a/0x30
[    3.475678]  [show_stack_log_lvl+177/224] show_stack_log_lvl+0xb1/0xe0
[    3.475695]  [die+282/560] die+0x11a/0x230
[    3.475687]  [show_registers+193/464] show_registers+0xc1/0x1d0
[    3.475703]  [do_page_fault+415/1648] do_page_fault+0x19f/0x670
[    3.475713]  [error_code+114/120] error_code+0x72/0x78
[    3.475722]  [__mutex_unlock_slowpath+172/336] __mutex_unlock_slowpath+0xac/0x150
[    3.475731]  [mutex_unlock+8/16] mutex_unlock+0x8/0x10
[    3.475739]  [<f896f3ed>] acpi_battery_update+0x1ce/0x23c [battery]
[    3.475753]  [<f896f927>] acpi_battery_notify+0x21/0x78 [battery]
[    3.475764]  [acpi_ev_notify_dispatch+79/90] acpi_ev_notify_dispatch+0x4f/0x5a
[    3.475792]  [worker_thread+157/256] worker_thread+0x9d/0x100
[    3.475774]  [acpi_os_execute_notify+36/47] acpi_os_execute_notify+0x24/0x2f
[    3.475784]  [run_workqueue+288/464] run_workqueue+0x120/0x1d0
[    3.475809]  [kernel_thread_helper+7/16] kernel_thread_helper+0x7/0x10
[    3.475801]  [kthread+66/112] kthread+0x42/0x70
[    3.475821] Code: 8d b4 26 00 00 00 00 55 89 e5 83 ec 18 89 5d f8 89 c3 89 75 fc 0f b6 40 04 89 d6 84 c0 7f 24 8d 43 20 3b 43 20 0f 84 e4 00 00 00 <3b> 76 10 0f 85 93 00 00 00 3b 36 90 74 47 8b 5d f8 8b 75 fc 89 
[    3.475818]  =======================
[    3.475909] EIP: [debug_mutex_wake_waiter+36/352] debug_mutex_wake_waiter+0x24/0x160 SS:ESP 0068:c2123ebc




-- 
Sorry for the disclaimer --- ¡I cannot stop it!



--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [2.6.24-rc1][BUG] Oops on battery removal
@ 2007-11-02 14:20 Rolf Eike Beer
  2007-11-02 15:32 ` [PATCH] ACPI: Battery: remove cycle from " Alexey Starikovskiy
  0 siblings, 1 reply; 25+ messages in thread
From: Rolf Eike Beer @ 2007-11-02 14:20 UTC (permalink / raw)
  To: Alexey Starikovskiy; +Cc: lenb, linux-acpi, kernel list

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

Alexey Starikovskiy wrote:
> Rolf Eike Beer wrote:
> > Alexey Starikovskiy wrote:
> >> Rolf Eike Beer wrote:
> >>> Alexey Starikovskiy wrote:
> >>>> Rolf Eike Beer wrote:
> >>>>> Rolf Eike Beer wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> this happened while I removed my battery on bootup. Complete dmesg
> >>>>>> is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was
> >>>>>> d919fd433b5823d1cf9d0688eb2eec183de9b74c).
> >>>>>
> >>>>> Ok, I found out that it has nothing to do with the actual removal as
> >>>>> it seems. When I start the laptop with battery already detached I get
> >>>>> the same error.
> >>>>
> >>>> Please check if this patch helps.
> >>>
> >>> It made things worse:
> >>
> >> How about this patch?
> >
> > Ehm, that is the same patch as before!
>
> Yes, sorry... Two patches in parallel -- not good.

Tested-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

It makes the crash go away. But there is something weird going on. Before I 
logged into X I did an "cat /proc/acpi/battery/BAT1/*" and it showed the 
battery as present with some (random?) values. Now I'm in X and everything 
looks fine there (as in "not present").

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [PATCH] ACPI: Battery: remove cycle from battery removal.
@ 2007-11-14 17:54 Alexey Starikovskiy
  2007-11-14 21:21 ` Rafael J. Wysocki
  0 siblings, 1 reply; 25+ messages in thread
From: Alexey Starikovskiy @ 2007-11-14 17:54 UTC (permalink / raw)
  To: LenBrown; +Cc: Linux-acpi

get_property() should not call battery_update(),
it also should call get_status() only if battery is present to
avoid cycle and oops.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Tested-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
Acked-by: Johannes Weiner <hannes@saeurebad.de>
---

 drivers/acpi/battery.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index c2ce0ad..192c244 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -132,7 +132,7 @@ static int acpi_battery_technology(struct acpi_battery *battery)
 	return POWER_SUPPLY_TECHNOLOGY_UNKNOWN;
 }
 
-static int acpi_battery_update(struct acpi_battery *battery);
+static int acpi_battery_get_state(struct acpi_battery *battery);
 
 static int acpi_battery_get_property(struct power_supply *psy,
 				     enum power_supply_property psp,
@@ -140,10 +140,11 @@ static int acpi_battery_get_property(struct power_supply *psy,
 {
 	struct acpi_battery *battery = to_acpi_battery(psy);
 
-	if ((!acpi_battery_present(battery)) &&
-	     psp != POWER_SUPPLY_PROP_PRESENT)
+	if (acpi_battery_present(battery)) {
+		/* run battery update only if it is present */
+		acpi_battery_get_state(battery);
+	} else if (psp != POWER_SUPPLY_PROP_PRESENT)
 		return -ENODEV;
-	acpi_battery_update(battery);
 	switch (psp) {
 	case POWER_SUPPLY_PROP_STATUS:
 		if (battery->state & 0x01)
@@ -457,6 +458,7 @@ static void sysfs_remove_battery(struct acpi_battery *battery)
 		return;
 	device_remove_file(battery->bat.dev, &alarm_attr);
 	power_supply_unregister(&battery->bat);
+	battery->bat.dev = NULL;
 }
 
 static int acpi_battery_update(struct acpi_battery *battery)


^ permalink raw reply related	[flat|nested] 25+ messages in thread
end of thread, other threads:[~2007-11-14 21:06 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-29 10:11 2.6.24-rc1: OOPS at acpi_battery_update Romano Giannetti
2007-10-29 10:11 ` Romano Giannetti
2007-11-01 23:14 ` Andrew Morton
2007-11-02 16:08   ` Rafael J. Wysocki
2007-11-04  9:34     ` *SPAM* " Romano Giannetti
2007-11-04  9:34       ` Romano Giannetti
2007-11-04 13:17       ` Rafael J. Wysocki
2007-11-04 23:29         ` Michael (rabenkind) Brandstetter
2007-11-05  0:18           ` Rafael J. Wysocki
2007-11-08 15:53             ` Johannes Weiner
2007-11-08 16:16               ` Rafael J. Wysocki
2007-11-08 16:11                 ` Alexey Starikovskiy
2007-11-08 16:46                   ` Johannes Weiner
2007-11-08 16:35                 ` Alexey Starikovskiy
2007-11-08 16:58                   ` Johannes Weiner
2007-11-09  4:34                   ` Andrew Morton
2007-11-09  9:36                     ` Alexey Starikovskiy
2007-11-09  9:49                       ` Andrew Morton
2007-11-13  8:35                         ` Alexey Starikovskiy
2007-11-13  8:59                           ` Andrew Morton
2007-11-13  9:23                           ` [PATCH] ACPI: Battery: remove cycle from battery removal Alexey Starikovskiy
  -- strict thread matches above, loose matches on Subject: below --
2007-11-02 14:20 [2.6.24-rc1][BUG] Oops on " Rolf Eike Beer
2007-11-02 15:32 ` [PATCH] ACPI: Battery: remove cycle from " Alexey Starikovskiy
2007-11-14 17:54 Alexey Starikovskiy
2007-11-14 21:21 ` Rafael J. Wysocki
2007-11-14 21:06   ` Alexey Starikovskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.