* [uml-devel] leak in do_ubd_request
@ 2007-11-27 16:23 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 16:23 UTC (permalink / raw)
To: jdike; +Cc: linux-kernel, user-mode-linux-devel
When writing big files on 2.6.24-rc3-mm1, there can be substiantial
number of leaked requests (CONFIG_DEBUG_SLAB_LEAK enabled):
# cat /proc/slab_allocators |grep do_ubd_request
size-128: 25687 do_ubd_request+0xe0/0x19d
There seems to be no corruption though. Looking at the code, I can't
see how the requests could leak...
Miklos
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* leak in do_ubd_request
@ 2007-11-27 16:23 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 16:23 UTC (permalink / raw)
To: jdike; +Cc: user-mode-linux-devel, linux-kernel
When writing big files on 2.6.24-rc3-mm1, there can be substiantial
number of leaked requests (CONFIG_DEBUG_SLAB_LEAK enabled):
# cat /proc/slab_allocators |grep do_ubd_request
size-128: 25687 do_ubd_request+0xe0/0x19d
There seems to be no corruption though. Looking at the code, I can't
see how the requests could leak...
Miklos
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-27 16:23 ` Miklos Szeredi
@ 2007-11-27 18:26 ` Miklos Szeredi
-1 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 18:26 UTC (permalink / raw)
To: jdike; +Cc: linux-kernel, user-mode-linux-devel
> There seems to be no corruption though. Looking at the code, I can't
> see how the requests could leak...
Didn't look close enough.
Index: linux/arch/um/drivers/ubd_kern.c
===================================================================
--- linux.orig/arch/um/drivers/ubd_kern.c 2007-11-27 19:23:37.000000000 +0100
+++ linux/arch/um/drivers/ubd_kern.c 2007-11-27 19:24:24.000000000 +0100
@@ -1132,6 +1132,7 @@ static void do_ubd_request(struct reques
"errno = %d\n", -n);
else if(list_empty(&dev->restart))
list_add(&dev->restart, &restart);
+ kfree(io_req);
return;
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: leak in do_ubd_request
@ 2007-11-27 18:26 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 18:26 UTC (permalink / raw)
To: jdike; +Cc: user-mode-linux-devel, linux-kernel
> There seems to be no corruption though. Looking at the code, I can't
> see how the requests could leak...
Didn't look close enough.
Index: linux/arch/um/drivers/ubd_kern.c
===================================================================
--- linux.orig/arch/um/drivers/ubd_kern.c 2007-11-27 19:23:37.000000000 +0100
+++ linux/arch/um/drivers/ubd_kern.c 2007-11-27 19:24:24.000000000 +0100
@@ -1132,6 +1132,7 @@ static void do_ubd_request(struct reques
"errno = %d\n", -n);
else if(list_empty(&dev->restart))
list_add(&dev->restart, &restart);
+ kfree(io_req);
return;
}
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-27 18:26 ` Miklos Szeredi
@ 2007-11-27 20:11 ` Jeff Dike
-1 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2007-11-27 20:11 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-kernel, user-mode-linux-devel
On Tue, Nov 27, 2007 at 07:26:38PM +0100, Miklos Szeredi wrote:
> + kfree(io_req);
Whoops, nice catch.
Can you sign that off for me?
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
@ 2007-11-27 20:11 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2007-11-27 20:11 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-kernel, user-mode-linux-devel
On Tue, Nov 27, 2007 at 07:26:38PM +0100, Miklos Szeredi wrote:
> + kfree(io_req);
Whoops, nice catch.
Can you sign that off for me?
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-27 20:11 ` Jeff Dike
@ 2007-11-27 20:29 ` Miklos Szeredi
-1 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 20:29 UTC (permalink / raw)
To: jdike; +Cc: linux-kernel, user-mode-linux-devel
> On Tue, Nov 27, 2007 at 07:26:38PM +0100, Miklos Szeredi wrote:
> > + kfree(io_req);
>
> Whoops, nice catch.
>
> Can you sign that off for me?
Sure. The patch works for me, but please check that it also makes
sense.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
@ 2007-11-27 20:29 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-27 20:29 UTC (permalink / raw)
To: jdike; +Cc: linux-kernel, user-mode-linux-devel
> On Tue, Nov 27, 2007 at 07:26:38PM +0100, Miklos Szeredi wrote:
> > + kfree(io_req);
>
> Whoops, nice catch.
>
> Can you sign that off for me?
Sure. The patch works for me, but please check that it also makes
sense.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-27 20:29 ` Miklos Szeredi
(?)
@ 2007-11-27 22:20 ` Jeff Dike
2007-11-28 5:38 ` Andrew Morton
-1 siblings, 1 reply; 14+ messages in thread
From: Jeff Dike @ 2007-11-27 22:20 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-kernel, user-mode-linux-devel
On Tue, Nov 27, 2007 at 09:29:23PM +0100, Miklos Szeredi wrote:
> Sure. The patch works for me, but please check that it also makes
> sense.
I did - it's a straight-forward leak and fix.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-27 22:20 ` Jeff Dike
@ 2007-11-28 5:38 ` Andrew Morton
2007-11-28 9:37 ` Miklos Szeredi
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Morton @ 2007-11-28 5:38 UTC (permalink / raw)
To: Jeff Dike; +Cc: Miklos Szeredi, linux-kernel, user-mode-linux-devel
On Tue, 27 Nov 2007 17:20:20 -0500 Jeff Dike <jdike@addtoit.com> wrote:
> On Tue, Nov 27, 2007 at 09:29:23PM +0100, Miklos Szeredi wrote:
> > Sure. The patch works for me, but please check that it also makes
> > sense.
>
> I did - it's a straight-forward leak and fix.
>
Do we have any idea which patch this patch fixes?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-28 5:38 ` Andrew Morton
@ 2007-11-28 9:37 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-28 9:37 UTC (permalink / raw)
To: akpm; +Cc: jdike, linux-kernel, user-mode-linux-devel
> On Tue, 27 Nov 2007 17:20:20 -0500 Jeff Dike <jdike@addtoit.com> wrote:
>
> > On Tue, Nov 27, 2007 at 09:29:23PM +0100, Miklos Szeredi wrote:
> > > Sure. The patch works for me, but please check that it also makes
> > > sense.
> >
> > I did - it's a straight-forward leak and fix.
> >
>
> Do we have any idea which patch this patch fixes?
I seems like a mainline bug, and has been present for some time
(forever?).
I have no idea why this wasn't noticed earlier.
Miklos
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
@ 2007-11-28 9:37 ` Miklos Szeredi
0 siblings, 0 replies; 14+ messages in thread
From: Miklos Szeredi @ 2007-11-28 9:37 UTC (permalink / raw)
To: akpm; +Cc: jdike, linux-kernel, user-mode-linux-devel
> On Tue, 27 Nov 2007 17:20:20 -0500 Jeff Dike <jdike@addtoit.com> wrote:
>
> > On Tue, Nov 27, 2007 at 09:29:23PM +0100, Miklos Szeredi wrote:
> > > Sure. The patch works for me, but please check that it also makes
> > > sense.
> >
> > I did - it's a straight-forward leak and fix.
> >
>
> Do we have any idea which patch this patch fixes?
I seems like a mainline bug, and has been present for some time
(forever?).
I have no idea why this wasn't noticed earlier.
Miklos
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [uml-devel] leak in do_ubd_request
2007-11-28 9:37 ` Miklos Szeredi
@ 2007-11-28 15:03 ` Jeff Dike
-1 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2007-11-28 15:03 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: akpm, linux-kernel, user-mode-linux-devel
On Wed, Nov 28, 2007 at 10:37:53AM +0100, Miklos Szeredi wrote:
> > Do we have any idea which patch this patch fixes?
>
> I seems like a mainline bug, and has been present for some time
> (forever?).
>
> I have no idea why this wasn't noticed earlier.
Not forever, but it's been there for a while - it was introduced here:
commit 2adcec2197897365e0a0f657f1098cbfdb44bc8b
Author: Jeff Dike <jdike@addtoit.com>
Date: Sun May 6 14:51:37 2007 -0700
uml: send pointers instead of structures to I/O thread
Instead of writing entire structures between UML and the I/O thread, we send
pointers. This cuts down on the amount of data being copied and possibly
allows more requests to be pending between the two.
This requires that the requests be kmalloced and freed instead of living on
the stack.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [uml-devel] leak in do_ubd_request
@ 2007-11-28 15:03 ` Jeff Dike
0 siblings, 0 replies; 14+ messages in thread
From: Jeff Dike @ 2007-11-28 15:03 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: akpm, linux-kernel, user-mode-linux-devel
On Wed, Nov 28, 2007 at 10:37:53AM +0100, Miklos Szeredi wrote:
> > Do we have any idea which patch this patch fixes?
>
> I seems like a mainline bug, and has been present for some time
> (forever?).
>
> I have no idea why this wasn't noticed earlier.
Not forever, but it's been there for a while - it was introduced here:
commit 2adcec2197897365e0a0f657f1098cbfdb44bc8b
Author: Jeff Dike <jdike@addtoit.com>
Date: Sun May 6 14:51:37 2007 -0700
uml: send pointers instead of structures to I/O thread
Instead of writing entire structures between UML and the I/O thread, we send
pointers. This cuts down on the amount of data being copied and possibly
allows more requests to be pending between the two.
This requires that the requests be kmalloced and freed instead of living on
the stack.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2007-11-28 15:04 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-27 16:23 [uml-devel] leak in do_ubd_request Miklos Szeredi
2007-11-27 16:23 ` Miklos Szeredi
2007-11-27 18:26 ` [uml-devel] " Miklos Szeredi
2007-11-27 18:26 ` Miklos Szeredi
2007-11-27 20:11 ` [uml-devel] " Jeff Dike
2007-11-27 20:11 ` Jeff Dike
2007-11-27 20:29 ` Miklos Szeredi
2007-11-27 20:29 ` Miklos Szeredi
2007-11-27 22:20 ` Jeff Dike
2007-11-28 5:38 ` Andrew Morton
2007-11-28 9:37 ` Miklos Szeredi
2007-11-28 9:37 ` Miklos Szeredi
2007-11-28 15:03 ` Jeff Dike
2007-11-28 15:03 ` Jeff Dike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.