From: Andrew Morton <akpm@linux-foundation.org>
To: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>
Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h
Date: Thu, 13 Dec 2007 02:31:11 -0800 [thread overview]
Message-ID: <20071213023111.30ddc487.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071209214027.GG9440@joi>
On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Åšlusarz <marcin.slusarz@gmail.com> wrote:
> logo: move declarations of logos to linux_logo.h
>
> there was a mismatch between externs in logo.c and code generated by pnmtologo
> (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
This patch (after I fixed it) keeps on causing trouble: mismatches between
the header file declarations and the actual definitions of the lookup
tables. This happens as I apply and unapply the patch.
It _shouldn't_ happen, but there would appear to be some missing makefile
rules. I guess the C files aren't being regenerated when
scripts/pnmtologo.c has been altered, so the C files aren't matching the
header which this patch alters.
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h
Date: Thu, 13 Dec 2007 02:31:11 -0800 [thread overview]
Message-ID: <20071213023111.30ddc487.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071209214027.GG9440@joi>
On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
> logo: move declarations of logos to linux_logo.h
>
> there was a mismatch between externs in logo.c and code generated by pnmtologo
> (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
This patch (after I fixed it) keeps on causing trouble: mismatches between
the header file declarations and the actual definitions of the lookup
tables. This happens as I apply and unapply the patch.
It _shouldn't_ happen, but there would appear to be some missing makefile
rules. I guess the C files aren't being regenerated when
scripts/pnmtologo.c has been altered, so the C files aren't matching the
header which this patch alters.
next prev parent reply other threads:[~2007-12-13 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:40 [PATCH] logo: move declarations of logos to linux_logo.h Marcin Ślusarz
2007-12-13 10:31 ` Andrew Morton [this message]
2007-12-13 10:31 ` Andrew Morton
2007-12-13 19:50 ` Marcin Ślusarz
2007-12-13 19:50 ` Marcin Ślusarz
2007-12-13 19:55 ` Sam Ravnborg
2007-12-13 19:55 ` Sam Ravnborg
2007-12-13 21:31 ` Marcin Slusarz
2007-12-13 21:31 ` Marcin Slusarz
2007-12-14 20:49 ` Geert Uytterhoeven
2007-12-14 20:49 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2007-12-14 22:00 ` Sam Ravnborg
2007-12-14 22:00 ` [Linux-fbdev-devel] " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213023111.30ddc487.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.