From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: gallatin@myri.com, jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
Date: Thu, 20 Dec 2007 16:05:18 -0800 [thread overview]
Message-ID: <20071220160518.fa65ac90.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071212.110243.202840959.davem@davemloft.net>
On Wed, 12 Dec 2007 11:02:43 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Andrew Gallatin <gallatin@myri.com>
> Date: Wed, 12 Dec 2007 13:38:34 -0500
>
> > Remove the bogus netif_running() check from myri10ge_poll().
> >
> > This eliminates any chance that myri10ge_poll() can trigger
> > an oops by calling netif_rx_complete() and returning
> > with work_done == budget.
> >
> > Signed-off-by: Andrew Gallatin <gallatin@myri.com>
>
> Acked-by: David S. Miller <davem@davemloft.net>
hm, eight days old, fixes a possible oops and hasn't been merged anywhere
yet?
I'll put it in my for-2.6.24-via-other-subsystem queue.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: gallatin@myri.com, jeff@garzik.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: remove netif_running() check from myri10ge_poll()
Date: Thu, 20 Dec 2007 16:05:18 -0800 [thread overview]
Message-ID: <20071220160518.fa65ac90.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071212.110243.202840959.davem@davemloft.net>
On Wed, 12 Dec 2007 11:02:43 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Andrew Gallatin <gallatin@myri.com>
> Date: Wed, 12 Dec 2007 13:38:34 -0500
>
> > Remove the bogus netif_running() check from myri10ge_poll().
> >
> > This eliminates any chance that myri10ge_poll() can trigger
> > an oops by calling netif_rx_complete() and returning
> > with work_done == budget.
> >
> > Signed-off-by: Andrew Gallatin <gallatin@myri.com>
>
> Acked-by: David S. Miller <davem@davemloft.net>
hm, eight days old, fixes a possible oops and hasn't been merged anywhere
yet?
I'll put it in my for-2.6.24-via-other-subsystem queue.
next prev parent reply other threads:[~2007-12-21 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 18:38 [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll() Andrew Gallatin
2007-12-12 18:38 ` [PATCH]: " Andrew Gallatin
2007-12-12 19:02 ` [PATCH][NETDEV]: " David Miller
2007-12-12 19:02 ` [PATCH]: " David Miller
2007-12-21 0:05 ` Andrew Morton [this message]
2007-12-21 0:05 ` Andrew Morton
2007-12-21 0:37 ` [PATCH][NETDEV]: " David Miller
2007-12-21 0:37 ` [PATCH]: " David Miller
2007-12-17 23:19 ` [PATCH][NETDEV]: " Jeff Garzik
2007-12-17 23:19 ` [PATCH]: " Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220160518.fa65ac90.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.