From: Andrew Gallatin <gallatin@myri.com>
To: David Miller <davem@davemloft.net>
Cc: Jeff Garzik <jeff@garzik.org>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()
Date: Wed, 12 Dec 2007 13:38:34 -0500 [thread overview]
Message-ID: <47602AAA.8060204@myri.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Remove the bogus netif_running() check from myri10ge_poll().
This eliminates any chance that myri10ge_poll() can trigger
an oops by calling netif_rx_complete() and returning
with work_done == budget.
Signed-off-by: Andrew Gallatin <gallatin@myri.com>
[-- Attachment #2: myri10ge_remove_netif_running.diff --]
[-- Type: text/plain, Size: 515 bytes --]
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 8def865..c90958f 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1239,7 +1239,7 @@ static int myri10ge_poll(struct napi_str
/* process as many rx events as NAPI will allow */
work_done = myri10ge_clean_rx_done(mgp, budget);
- if (work_done < budget || !netif_running(netdev)) {
+ if (work_done < budget) {
netif_rx_complete(netdev, napi);
put_be32(htonl(3), mgp->irq_claim);
}
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Gallatin <gallatin@myri.com>
To: David Miller <davem@davemloft.net>
Cc: Jeff Garzik <jeff@garzik.org>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH]: remove netif_running() check from myri10ge_poll()
Date: Wed, 12 Dec 2007 13:38:34 -0500 [thread overview]
Message-ID: <47602AAA.8060204@myri.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Remove the bogus netif_running() check from myri10ge_poll().
This eliminates any chance that myri10ge_poll() can trigger
an oops by calling netif_rx_complete() and returning
with work_done == budget.
Signed-off-by: Andrew Gallatin <gallatin@myri.com>
[-- Attachment #2: myri10ge_remove_netif_running.diff --]
[-- Type: text/plain, Size: 515 bytes --]
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 8def865..c90958f 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -1239,7 +1239,7 @@ static int myri10ge_poll(struct napi_str
/* process as many rx events as NAPI will allow */
work_done = myri10ge_clean_rx_done(mgp, budget);
- if (work_done < budget || !netif_running(netdev)) {
+ if (work_done < budget) {
netif_rx_complete(netdev, napi);
put_be32(htonl(3), mgp->irq_claim);
}
next reply other threads:[~2007-12-12 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 18:38 Andrew Gallatin [this message]
2007-12-12 18:38 ` [PATCH]: remove netif_running() check from myri10ge_poll() Andrew Gallatin
2007-12-12 19:02 ` [PATCH][NETDEV]: " David Miller
2007-12-12 19:02 ` [PATCH]: " David Miller
2007-12-21 0:05 ` [PATCH][NETDEV]: " Andrew Morton
2007-12-21 0:05 ` [PATCH]: " Andrew Morton
2007-12-21 0:37 ` [PATCH][NETDEV]: " David Miller
2007-12-21 0:37 ` [PATCH]: " David Miller
2007-12-17 23:19 ` [PATCH][NETDEV]: " Jeff Garzik
2007-12-17 23:19 ` [PATCH]: " Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47602AAA.8060204@myri.com \
--to=gallatin@myri.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.