All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.linux-foundation.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Pavel Machek <pavel@suse.cz>, Ingo Molnar <mingo@elte.hu>,
	Greg KH <gregkh@suse.de>
Subject: [PATCH 2/4] PM: Do not destroy/create devices while suspended in msr.c (rev. 2)
Date: Wed, 2 Jan 2008 00:40:01 +0100	[thread overview]
Message-ID: <200801020040.02190.rjw@sisk.pl> (raw)
In-Reply-To: <200801020032.45529.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

The MSR driver should not attempt to destroy/create a device while
suspended, unless this device corresponds to a nonboot CPU that
failed to go online during a resume, in which case the PM core should
be asked to remove it.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/x86/kernel/msr.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/arch/x86/kernel/msr.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/msr.c
+++ linux-2.6/arch/x86/kernel/msr.c
@@ -155,15 +155,15 @@ static int __cpuinit msr_class_cpu_callb
 
 	switch (action) {
 	case CPU_UP_PREPARE:
-	case CPU_UP_PREPARE_FROZEN:
 		err = msr_device_create(cpu);
 		break;
 	case CPU_UP_CANCELED:
-	case CPU_UP_CANCELED_FROZEN:
 	case CPU_DEAD:
-	case CPU_DEAD_FROZEN:
 		msr_device_destroy(cpu);
 		break;
+	case CPU_UP_CANCELED_FROZEN:
+		destroy_suspended_device(msr_class, MKDEV(MSR_MAJOR, cpu));
+		break;
 	}
 	return err ? NOTIFY_BAD : NOTIFY_OK;
 }


  parent reply	other threads:[~2008-01-01 23:40 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-01 23:32 [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2) Rafael J. Wysocki
2008-01-01 23:32 ` Rafael J. Wysocki
2008-01-01 23:34 ` [PATCH 1/4] PM: Introduce destroy_suspended_device() Rafael J. Wysocki
2008-01-01 23:34 ` Rafael J. Wysocki
2008-01-02 13:33   ` Rafael J. Wysocki
2008-01-02 13:33   ` Rafael J. Wysocki
2008-01-02 16:41     ` Alan Stern
2008-01-02 16:41     ` Alan Stern
2008-01-02 16:50       ` Rafael J. Wysocki
2008-01-02 16:50       ` Rafael J. Wysocki
2008-01-04 22:05         ` Rafael J. Wysocki
2008-01-04 23:29           ` [RFC][PATCH] PM: Acquire device locks on suspend (was: Re: [PATCH 1/4] PM: Introduce destroy_suspended_device()) Rafael J. Wysocki
2008-01-04 23:29           ` Rafael J. Wysocki
2008-01-05  3:11           ` [PATCH 1/4] PM: Introduce destroy_suspended_device() Alan Stern
2008-01-05 11:55             ` Rafael J. Wysocki
2008-01-05 11:55             ` Rafael J. Wysocki
2008-01-05  3:11           ` Alan Stern
2008-01-04 22:05         ` Rafael J. Wysocki
2008-01-01 23:40 ` [PATCH 2/4] PM: Do not destroy/create devices while suspended in msr.c (rev. 2) Rafael J. Wysocki
2008-01-01 23:40 ` Rafael J. Wysocki [this message]
2008-01-01 23:40 ` [PATCH 3/4] PM: Do not destroy/create devices while suspended in mce_64.c Rafael J. Wysocki
2008-01-01 23:40 ` Rafael J. Wysocki
2008-01-01 23:42 ` [PATCH 4/4] PM: Do not destroy/create devices while suspended in cpuid.c Rafael J. Wysocki
2008-01-01 23:42 ` Rafael J. Wysocki
2008-01-02 10:52 ` [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2) Ingo Molnar
2008-01-02 10:52 ` Ingo Molnar
2008-01-02 10:52   ` Ingo Molnar
2008-01-02 12:56   ` Rafael J. Wysocki
2008-01-02 12:56   ` Rafael J. Wysocki
2008-01-02 12:56     ` Rafael J. Wysocki
2008-01-02 13:15     ` Ingo Molnar
2008-01-02 13:28       ` Rafael J. Wysocki
2008-01-02 13:28       ` Rafael J. Wysocki
2008-01-03 10:56         ` Pavel Machek
2008-01-03 10:56         ` Pavel Machek
2008-01-02 14:55       ` Kay Sievers
2008-01-02 16:01         ` Ingo Molnar
2008-01-02 16:01         ` Ingo Molnar
2008-01-02 17:54           ` David Brownell
2008-01-02 17:54           ` David Brownell
2008-01-02 17:54             ` David Brownell
2008-01-02 18:05             ` Alessandro Zummo
2008-01-02 18:05             ` Alessandro Zummo
2008-01-02 18:05               ` Alessandro Zummo
2008-01-02 18:12               ` David Brownell
2008-01-02 18:12                 ` David Brownell
2008-01-02 18:34                 ` Alessandro Zummo
2008-01-02 18:34                 ` Alessandro Zummo
2008-01-02 18:34                   ` Alessandro Zummo
2008-01-02 18:12               ` David Brownell
2008-01-02 20:14             ` Ingo Molnar
2008-01-02 20:14             ` Ingo Molnar
2008-01-02 20:29               ` David Brownell
2008-01-02 20:29               ` David Brownell
2008-01-02 14:55       ` Kay Sievers
2008-01-02 17:26       ` David Brownell
2008-01-02 17:26         ` David Brownell
2008-01-02 20:17         ` Ingo Molnar
2008-01-02 20:17         ` Ingo Molnar
2008-01-02 17:26       ` David Brownell
2008-01-02 13:15     ` Ingo Molnar
2008-01-12  0:46 ` Andrew Morton
2008-01-12  0:46 ` Andrew Morton
2008-01-12  0:49   ` Andrew Morton
2008-01-12  0:49     ` Andrew Morton
2008-01-12  0:56     ` Greg KH
2008-01-12  0:56     ` Greg KH
2008-01-12  3:11       ` Alan Stern
2008-01-12  3:11         ` Alan Stern
2008-01-12  3:15         ` Andi Kleen
2008-01-12  3:15         ` Andi Kleen
2008-01-12  3:21         ` Andrew Morton
2008-01-12  3:21           ` Andrew Morton
2008-01-12  4:29         ` Greg KH
2008-01-12  4:29         ` Greg KH
2008-01-12 11:25           ` Rafael J. Wysocki
2008-01-12 11:25           ` Rafael J. Wysocki
2008-01-12  3:11       ` Alan Stern
2008-01-12 11:20     ` Rafael J. Wysocki
2008-01-12 11:20     ` Rafael J. Wysocki
2008-01-12  0:49   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801020040.02190.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.