From: Richard Knutsson <ricknu-0@student.ltu.se>
To: James.Bottomley@SteelEye.com
Cc: kernel-janitors@vger.kernel.org, trivial@kernel.org,
linux-scsi@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: [PATCH 18/33][SCSI] ibmmca: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'
Date: Sun, 06 Jan 2008 03:04:22 +0000 [thread overview]
Message-ID: <20080106030422.30002.76264.sendpatchset@thinktank.campus.ltu.se> (raw)
In-Reply-To: <20080106030250.30002.96493.sendpatchset@thinktank.campus.ltu.se>
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning).
diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c
index db004a4..5863d70 100644
--- a/drivers/scsi/ibmmca.c
+++ b/drivers/scsi/ibmmca.c
@@ -39,9 +39,9 @@
#include <scsi/scsi_host.h>
/* Common forward declarations for all Linux-versions: */
-static int ibmmca_queuecommand (Scsi_Cmnd *, void (*done) (Scsi_Cmnd *));
-static int ibmmca_abort (Scsi_Cmnd *);
-static int ibmmca_host_reset (Scsi_Cmnd *);
+static int ibmmca_queuecommand(struct scsi_cmnd *, void (*done) (struct scsi_cmnd *));
+static int ibmmca_abort(struct scsi_cmnd *);
+static int ibmmca_host_reset(struct scsi_cmnd *);
static int ibmmca_biosparam (struct scsi_device *, struct block_device *, sector_t, int *);
static int ibmmca_proc_info(struct Scsi_Host *shpnt, char *buffer, char **start, off_t offset, int length, int inout);
@@ -315,7 +315,7 @@ struct logical_device {
struct im_tsb tsb; /* SCSI command complete status block structure */
struct im_sge sge[16]; /* scatter gather list structure */
unsigned char buf[256]; /* SCSI command return data buffer */
- Scsi_Cmnd *cmd; /* SCSI-command that is currently in progress */
+ struct scsi_cmnd *cmd; /* SCSI-command that is currently in progress */
int device_type; /* type of the SCSI-device. See include/scsi/scsi.h
for interpretation of the possible values */
int block_length; /* blocksize of a particular logical SCSI-device */
@@ -476,7 +476,7 @@ static char ibm_ansi_order = 0;
#endif
static void issue_cmd(struct Scsi_Host *, unsigned long, unsigned char);
-static void internal_done(Scsi_Cmnd * cmd);
+static void internal_done(struct scsi_cmnd *cmd);
static void check_devices(struct Scsi_Host *, int);
static int immediate_assign(struct Scsi_Host *, unsigned int, unsigned int, unsigned int, unsigned int);
static int immediate_feature(struct Scsi_Host *, unsigned int, unsigned int);
@@ -503,7 +503,7 @@ static irqreturn_t interrupt_handler(int irq, void *dev_id)
unsigned int cmd_result;
unsigned int ldn;
unsigned long flags;
- Scsi_Cmnd *cmd;
+ struct scsi_cmnd *cmd;
int lastSCSI;
struct device *dev = dev_id;
struct Scsi_Host *shpnt = dev_get_drvdata(dev);
@@ -726,7 +726,7 @@ static void issue_cmd(struct Scsi_Host *shpnt, unsigned long cmd_reg,
spin_unlock_irqrestore(shpnt->host_lock, flags);
}
-static void internal_done(Scsi_Cmnd * cmd)
+static void internal_done(struct scsi_cmnd *cmd)
{
cmd->SCp.Status++;
return;
@@ -1692,7 +1692,7 @@ static int __devexit ibmmca_remove(struct device *dev)
}
/* The following routine is the SCSI command queue for the midlevel driver */
-static int ibmmca_queuecommand(Scsi_Cmnd * cmd, void (*done) (Scsi_Cmnd *))
+static int ibmmca_queuecommand(struct scsi_cmnd *cmd, void (*done) (struct scsi_cmnd *))
{
unsigned int ldn;
unsigned int scsi_cmd;
@@ -1997,7 +1997,7 @@ static int ibmmca_queuecommand(Scsi_Cmnd * cmd, void (*done) (Scsi_Cmnd *))
return 0;
}
-static int __ibmmca_abort(Scsi_Cmnd * cmd)
+static int __ibmmca_abort(struct scsi_cmnd *cmd)
{
/* Abort does not work, as the adapter never generates an interrupt on
* whatever situation is simulated, even when really pending commands
@@ -2005,7 +2005,7 @@ static int __ibmmca_abort(Scsi_Cmnd * cmd)
struct Scsi_Host *shpnt;
unsigned int ldn;
- void (*saved_done) (Scsi_Cmnd *);
+ void (*saved_done) (struct scsi_cmnd *);
int target;
int max_pun;
unsigned long imm_command;
@@ -2091,7 +2091,7 @@ static int __ibmmca_abort(Scsi_Cmnd * cmd)
}
}
-static int ibmmca_abort(Scsi_Cmnd * cmd)
+static int ibmmca_abort(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt = cmd->device->host;
int rc;
@@ -2103,10 +2103,10 @@ static int ibmmca_abort(Scsi_Cmnd * cmd)
return rc;
}
-static int __ibmmca_host_reset(Scsi_Cmnd * cmd)
+static int __ibmmca_host_reset(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt;
- Scsi_Cmnd *cmd_aid;
+ struct scsi_cmnd *cmd_aid;
int ticks, i;
unsigned long imm_command;
@@ -2183,7 +2183,7 @@ static int __ibmmca_host_reset(Scsi_Cmnd * cmd)
return SUCCESS;
}
-static int ibmmca_host_reset(Scsi_Cmnd * cmd)
+static int ibmmca_host_reset(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt = cmd->device->host;
int rc;
WARNING: multiple messages have this Message-ID (diff)
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: James.Bottomley@SteelEye.com
Cc: kernel-janitors@vger.kernel.org, trivial@kernel.org,
linux-scsi@vger.kernel.org,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: [PATCH 18/33][SCSI] ibmmca: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'
Date: Sun, 6 Jan 2008 04:04:22 +0100 (MET) [thread overview]
Message-ID: <20080106030422.30002.76264.sendpatchset@thinktank.campus.ltu.se> (raw)
In-Reply-To: <20080106030250.30002.96493.sendpatchset@thinktank.campus.ltu.se>
Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Last item before 'drivers/scsi/scsi_typedefs.h' can be removed.
Cleaned up checkpatch.pl-errors (so no '> 80 lines'-warning).
diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c
index db004a4..5863d70 100644
--- a/drivers/scsi/ibmmca.c
+++ b/drivers/scsi/ibmmca.c
@@ -39,9 +39,9 @@
#include <scsi/scsi_host.h>
/* Common forward declarations for all Linux-versions: */
-static int ibmmca_queuecommand (Scsi_Cmnd *, void (*done) (Scsi_Cmnd *));
-static int ibmmca_abort (Scsi_Cmnd *);
-static int ibmmca_host_reset (Scsi_Cmnd *);
+static int ibmmca_queuecommand(struct scsi_cmnd *, void (*done) (struct scsi_cmnd *));
+static int ibmmca_abort(struct scsi_cmnd *);
+static int ibmmca_host_reset(struct scsi_cmnd *);
static int ibmmca_biosparam (struct scsi_device *, struct block_device *, sector_t, int *);
static int ibmmca_proc_info(struct Scsi_Host *shpnt, char *buffer, char **start, off_t offset, int length, int inout);
@@ -315,7 +315,7 @@ struct logical_device {
struct im_tsb tsb; /* SCSI command complete status block structure */
struct im_sge sge[16]; /* scatter gather list structure */
unsigned char buf[256]; /* SCSI command return data buffer */
- Scsi_Cmnd *cmd; /* SCSI-command that is currently in progress */
+ struct scsi_cmnd *cmd; /* SCSI-command that is currently in progress */
int device_type; /* type of the SCSI-device. See include/scsi/scsi.h
for interpretation of the possible values */
int block_length; /* blocksize of a particular logical SCSI-device */
@@ -476,7 +476,7 @@ static char ibm_ansi_order = 0;
#endif
static void issue_cmd(struct Scsi_Host *, unsigned long, unsigned char);
-static void internal_done(Scsi_Cmnd * cmd);
+static void internal_done(struct scsi_cmnd *cmd);
static void check_devices(struct Scsi_Host *, int);
static int immediate_assign(struct Scsi_Host *, unsigned int, unsigned int, unsigned int, unsigned int);
static int immediate_feature(struct Scsi_Host *, unsigned int, unsigned int);
@@ -503,7 +503,7 @@ static irqreturn_t interrupt_handler(int irq, void *dev_id)
unsigned int cmd_result;
unsigned int ldn;
unsigned long flags;
- Scsi_Cmnd *cmd;
+ struct scsi_cmnd *cmd;
int lastSCSI;
struct device *dev = dev_id;
struct Scsi_Host *shpnt = dev_get_drvdata(dev);
@@ -726,7 +726,7 @@ static void issue_cmd(struct Scsi_Host *shpnt, unsigned long cmd_reg,
spin_unlock_irqrestore(shpnt->host_lock, flags);
}
-static void internal_done(Scsi_Cmnd * cmd)
+static void internal_done(struct scsi_cmnd *cmd)
{
cmd->SCp.Status++;
return;
@@ -1692,7 +1692,7 @@ static int __devexit ibmmca_remove(struct device *dev)
}
/* The following routine is the SCSI command queue for the midlevel driver */
-static int ibmmca_queuecommand(Scsi_Cmnd * cmd, void (*done) (Scsi_Cmnd *))
+static int ibmmca_queuecommand(struct scsi_cmnd *cmd, void (*done) (struct scsi_cmnd *))
{
unsigned int ldn;
unsigned int scsi_cmd;
@@ -1997,7 +1997,7 @@ static int ibmmca_queuecommand(Scsi_Cmnd * cmd, void (*done) (Scsi_Cmnd *))
return 0;
}
-static int __ibmmca_abort(Scsi_Cmnd * cmd)
+static int __ibmmca_abort(struct scsi_cmnd *cmd)
{
/* Abort does not work, as the adapter never generates an interrupt on
* whatever situation is simulated, even when really pending commands
@@ -2005,7 +2005,7 @@ static int __ibmmca_abort(Scsi_Cmnd * cmd)
struct Scsi_Host *shpnt;
unsigned int ldn;
- void (*saved_done) (Scsi_Cmnd *);
+ void (*saved_done) (struct scsi_cmnd *);
int target;
int max_pun;
unsigned long imm_command;
@@ -2091,7 +2091,7 @@ static int __ibmmca_abort(Scsi_Cmnd * cmd)
}
}
-static int ibmmca_abort(Scsi_Cmnd * cmd)
+static int ibmmca_abort(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt = cmd->device->host;
int rc;
@@ -2103,10 +2103,10 @@ static int ibmmca_abort(Scsi_Cmnd * cmd)
return rc;
}
-static int __ibmmca_host_reset(Scsi_Cmnd * cmd)
+static int __ibmmca_host_reset(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt;
- Scsi_Cmnd *cmd_aid;
+ struct scsi_cmnd *cmd_aid;
int ticks, i;
unsigned long imm_command;
@@ -2183,7 +2183,7 @@ static int __ibmmca_host_reset(Scsi_Cmnd * cmd)
return SUCCESS;
}
-static int ibmmca_host_reset(Scsi_Cmnd * cmd)
+static int ibmmca_host_reset(struct scsi_cmnd *cmd)
{
struct Scsi_Host *shpnt = cmd->device->host;
int rc;
next prev parent reply other threads:[~2008-01-06 3:04 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 3:02 [PATCH 0/33][SCSI] Arrange for removal of 'scsi_typedefs.h' Richard Knutsson
2008-01-06 3:02 ` Richard Knutsson
2008-01-06 3:02 ` [PATCH 1/33][SCSI] 3w-xxxx: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd' Richard Knutsson
2008-01-06 3:02 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 2/33][SCSI] advansys: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 3/33][SCSI] aha152x: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 4/33][SCSI] aha1542: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 5/33][SCSI] aha1740: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 6/33][SCSI] atari_NCR5380: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 7/33][SCSI] atari_scsi: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 8/33][SCSI] blz1230: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 9/33][SCSI] blz2060: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 10/33][SCSI] cyberstorm: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 11/33][SCSI] cyberstormII: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 12/33][SCSI] dtc: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:03 ` [PATCH 13/33][SCSI] fastlane: " Richard Knutsson
2008-01-06 3:03 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 14/33][SCSI] fd_mcs: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 15/33][SCSI] gdth: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 16/33][SCSI] gdth_proc: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 17/33][SCSI] g_NCR5380: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson [this message]
2008-01-06 3:04 ` [PATCH 18/33][SCSI] ibmmca: " Richard Knutsson
2008-01-06 3:04 ` [PATCH 19/33][SCSI] ibmvscsi: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 20/33][SCSI] in2000: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 21/33][SCSI] mac_esp: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 22/33][SCSI] mca_53c9x: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 23/33][SCSI] megaraid: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 24/33][SCSI] NCR5380: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:04 ` [PATCH 25/33][SCSI] NCR53c406a: " Richard Knutsson
2008-01-06 3:04 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 26/33][SCSI] NCR53C9x: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 27/33][SCSI] nsp32_debug: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 28/33][SCSI] oktagon_esp: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 29/33][SCSI] pas16: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 30/33][SCSI] sun3x_esp: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 31/33][SCSI] sym53c416: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 32/33][SCSI] wd7000: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 33a/33] include/scsi/scsi_tcq.h: " Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 3:05 ` [PATCH 33b/33] include/scsi/scsi_tcq.h: Correct the parameter-name Richard Knutsson
2008-01-06 3:05 ` Richard Knutsson
2008-01-06 19:51 ` [PATCH 0/33][SCSI] Arrange for removal of 'scsi_typedefs.h' James Bottomley
2008-01-06 19:51 ` James Bottomley
2008-01-06 21:18 ` Richard Knutsson
2008-01-06 21:18 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106030422.30002.76264.sendpatchset@thinktank.campus.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=James.Bottomley@SteelEye.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.