All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Mon, 7 Jan 2008 13:37:17 +0000	[thread overview]
Message-ID: <20080107133716.GA6497@sirena.org.uk> (raw)
In-Reply-To: <477EEEC5.9050603@freescale.com>

On Fri, Jan 04, 2008 at 08:43:17PM -0600, Timur Tabi wrote:
> Mark Brown wrote:

> In other words, ...

> clock1 = <0, bb8000>
> clock2 = <1, 653230>
> clock23 = <0, ab2372>

Yes, something like that would cover it.  I'm not sure what is idiomatic
for the device tree.

> > and of course the ordering matters.  

> Ok, you got me there.  But then, isn't this just another example where the 
> device tree is incapable of describing a complex configuration, and so we need 
> a platform driver?

Yes, you could certainly do that - as you say, any device tree based
configuration would be optional so it's not a blocker if some things
aren't supported.

It'd be nice to have some idea of how to handle it should someone want
to do it but I wouldn't think it's essential.  The most common case
where specific ordering is required is that a PLL will need to have all
its inputs configured before the PLL is activated so it'd probably cover
a large proportion of cases to do that last.

> > Indeed.  Providing the device tree stuff doesn't get set in stone I'm
> > not sure we need to nail this down perfectly for ASoC v1 when we're
> > running into trouble working around it.

> I definitely agree with that.  I'll be the first to admit that this driver, 
> much like ASoC V1, is a prototype.

Yes, from an ASoC point of view the driver looks good as it is.  The
only discussion is about the PowerPC probing stuff.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Mon, 7 Jan 2008 13:37:17 +0000	[thread overview]
Message-ID: <20080107133716.GA6497@sirena.org.uk> (raw)
In-Reply-To: <477EEEC5.9050603@freescale.com>

On Fri, Jan 04, 2008 at 08:43:17PM -0600, Timur Tabi wrote:
> Mark Brown wrote:

> In other words, ...

> clock1 = <0, bb8000>
> clock2 = <1, 653230>
> clock23 = <0, ab2372>

Yes, something like that would cover it.  I'm not sure what is idiomatic
for the device tree.

> > and of course the ordering matters.  

> Ok, you got me there.  But then, isn't this just another example where the 
> device tree is incapable of describing a complex configuration, and so we need 
> a platform driver?

Yes, you could certainly do that - as you say, any device tree based
configuration would be optional so it's not a blocker if some things
aren't supported.

It'd be nice to have some idea of how to handle it should someone want
to do it but I wouldn't think it's essential.  The most common case
where specific ordering is required is that a PLL will need to have all
its inputs configured before the PLL is activated so it'd probably cover
a large proportion of cases to do that last.

> > Indeed.  Providing the device tree stuff doesn't get set in stone I'm
> > not sure we need to nail this down perfectly for ASoC v1 when we're
> > running into trouble working around it.

> I definitely agree with that.  I'll be the first to admit that this driver, 
> much like ASoC V1, is a prototype.

Yes, from an ASoC point of view the driver looks good as it is.  The
only discussion is about the PowerPC probing stuff.

  reply	other threads:[~2008-01-07 13:37 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  0:03 [PATCH] ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2007-12-20  4:06 ` Olof Johansson
2007-12-20 14:24   ` Timur Tabi
2007-12-20 13:54     ` Takashi Iwai
2007-12-20 13:54       ` [alsa-devel] " Takashi Iwai
2007-12-20 17:04       ` Timur Tabi
2007-12-20 17:04         ` [alsa-devel] " Timur Tabi
2007-12-21  5:28       ` Lee Revell
2007-12-21  5:28         ` [alsa-devel] " Lee Revell
2007-12-23  3:23         ` Timur Tabi
2007-12-23  3:23           ` [alsa-devel] " Timur Tabi
2007-12-20 22:39     ` Olof Johansson
2007-12-20 22:37       ` Timur Tabi
2007-12-20 22:43         ` Scott Wood
2007-12-23  2:58           ` Timur Tabi
2008-01-02 18:08             ` Scott Wood
2007-12-20 14:47 ` Jon Loeliger
2007-12-20 22:29 ` Jon Smirl
2007-12-20 22:32   ` Timur Tabi
2007-12-20 22:38     ` Jon Smirl
2007-12-20 22:40       ` Timur Tabi
2007-12-20 22:44         ` Scott Wood
2007-12-20 23:13           ` Jon Smirl
2007-12-21  0:00             ` David Gibson
2008-01-01 17:25 ` Jon Smirl
2008-01-01 17:42   ` Jon Smirl
2008-01-02 15:19     ` Timur Tabi
2008-01-02 15:34       ` Jon Smirl
2008-01-03 17:54         ` Timur Tabi
2008-01-03 18:13           ` Grant Likely
2008-01-03 18:20             ` Timur Tabi
2008-01-03 18:32               ` Grant Likely
2008-01-03 23:51           ` David Gibson
2008-01-05  2:39             ` Timur Tabi
2008-01-05  2:39               ` [alsa-devel] " Timur Tabi
2008-01-06  0:46               ` David Gibson
2008-01-06  0:46                 ` [alsa-devel] " David Gibson
2008-01-07 14:24                 ` Mark Brown
2008-01-07 14:24                   ` [alsa-devel] " Mark Brown
2008-01-07 15:52                 ` Timur Tabi
2008-01-07 15:52                   ` [alsa-devel] " Timur Tabi
2008-01-07 18:28                   ` Mark Brown
2008-01-07 18:28                     ` [alsa-devel] " Mark Brown
2008-01-10  3:49                     ` David Gibson
2008-01-10  3:49                       ` [alsa-devel] " David Gibson
2008-01-10  5:41                       ` Jon Smirl
2008-01-10  5:41                         ` [alsa-devel] " Jon Smirl
2008-01-10 10:30                         ` Liam Girdwood
2008-01-10 10:30                           ` [alsa-devel] " Liam Girdwood
2008-01-10 15:39                           ` Timur Tabi
2008-01-10 15:39                             ` [alsa-devel] " Timur Tabi
2008-01-10 16:01                             ` Grant Likely
2008-01-10 16:01                               ` [alsa-devel] " Grant Likely
2008-01-10 16:03                               ` Timur Tabi
2008-01-10 16:03                                 ` [alsa-devel] " Timur Tabi
2008-01-10 20:10                                 ` Jon Smirl
2008-01-10 20:10                                   ` [alsa-devel] " Jon Smirl
2008-01-10 20:13                                   ` Timur Tabi
2008-01-10 20:13                                     ` [alsa-devel] " Timur Tabi
2008-01-10 20:24                                     ` Grant Likely
2008-01-10 20:24                                       ` [alsa-devel] " Grant Likely
2008-01-10 20:35                                       ` Timur Tabi
2008-01-10 20:35                                         ` [alsa-devel] " Timur Tabi
2008-01-10 20:39                                     ` Jon Smirl
2008-01-10 20:39                                       ` [alsa-devel] " Jon Smirl
2008-01-10 20:44                                       ` Timur Tabi
2008-01-10 20:44                                         ` [alsa-devel] " Timur Tabi
2008-01-07 18:44                   ` Liam Girdwood
2008-01-07 18:44                     ` [alsa-devel] " Liam Girdwood
2008-01-07 18:45                     ` Timur Tabi
2008-01-07 18:45                       ` [alsa-devel] " Timur Tabi
2008-01-02 16:12       ` Grant Likely
2008-01-03 18:08         ` Timur Tabi
2008-01-03 18:17           ` Grant Likely
2008-01-03 18:54             ` Scott Wood
2008-01-03 19:13               ` Grant Likely
2008-01-03 19:18                 ` Scott Wood
2008-01-03 23:13                   ` Mark Brown
2008-01-03 23:13                     ` [alsa-devel] " Mark Brown
2008-01-05  2:35                 ` Timur Tabi
2008-01-05  3:28                   ` Grant Likely
2008-01-02  0:26   ` David Gibson
2008-01-02 15:10   ` Timur Tabi
2008-01-02 17:23     ` Mark Brown
2008-01-02 17:23       ` [alsa-devel] " Mark Brown
2008-01-03 18:23       ` Timur Tabi
2008-01-03 18:23         ` [alsa-devel] " Timur Tabi
2008-01-03 23:00         ` Mark Brown
2008-01-03 23:00           ` [alsa-devel] " Mark Brown
2008-01-05  2:43           ` Timur Tabi
2008-01-05  2:43             ` [alsa-devel] " Timur Tabi
2008-01-07 13:37             ` Mark Brown [this message]
2008-01-07 13:37               ` Mark Brown
2008-01-02  4:27 ` Jon Smirl
2008-01-02 15:29   ` Timur Tabi
2008-01-02 15:56     ` Jon Smirl
2008-01-02 16:32       ` Grant Likely
2008-01-02 17:12         ` Jon Smirl
2008-01-02 17:22           ` Grant Likely
2008-01-02 18:43             ` Jon Smirl
2008-01-02 18:50               ` Grant Likely
2008-01-02 18:56                 ` Jon Smirl
2008-01-03  4:46           ` David Gibson
2008-01-03  4:46             ` David Gibson
2008-01-03 14:33             ` Jon Smirl
2008-01-03 17:57       ` Timur Tabi
2008-01-02 16:28     ` Grant Likely
2008-01-02 18:49       ` Mark Brown
2008-01-02 18:49         ` [alsa-devel] " Mark Brown
2008-01-03 18:16         ` Timur Tabi
2008-01-03 18:16           ` [alsa-devel] " Timur Tabi
2008-01-03 23:47           ` David Gibson
2008-01-03 23:47             ` [alsa-devel] " David Gibson
2008-01-04 13:39             ` Mark Brown
2008-01-04 13:39               ` [alsa-devel] " Mark Brown
2008-01-03 18:14       ` Timur Tabi
2008-01-03 18:25         ` Grant Likely
2008-01-03 18:28           ` Timur Tabi
2008-01-03 18:38             ` Grant Likely
2008-01-03  4:44     ` David Gibson
2008-01-03 14:54       ` Jon Smirl
2008-01-04  5:01         ` David Gibson
2008-01-03 18:16       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080107133716.GA6497@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.