From: Timur Tabi <timur@freescale.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Takashi Iwai <tiwai@suse.de>, Olof Johansson <olof@lixom.net>,
alsa-devel@alsa-project.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Sat, 22 Dec 2007 21:23:48 -0600 [thread overview]
Message-ID: <476DD4C4.5030708@freescale.com> (raw)
In-Reply-To: <75b66ecd0712202128n2f13adf2ie9a344e0c19d69ad@mail.gmail.com>
Lee Revell wrote:
> Please use DMA_32BIT_MASK (see include/linux/dma-mapping.h) instead of
> 0xffffffff.
No prob. But did you see this comment:
/*
* NOTE: do not use the below macros in new code and do not add new
definitions
* here.
*
* Instead, just open-code DMA_BIT_MASK(n) within your driver
*/
So I guess I should use DMA_BIT_MASK(32) instead.
> I've personally fixed a heisenbug in an ALSA driver
> caused by incorrectly typed DMA mask...
Can you explain to me what all of this does? Is it okay to use a static
u64 variable? Why do so many drivers do it that way? I don't even know
if 0xFFFFFFFF is the right number for my platform.
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Takashi Iwai <tiwai@suse.de>, Olof Johansson <olof@lixom.net>,
alsa-devel@alsa-project.org, linuxppc-dev@ozlabs.org
Subject: Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC
Date: Sat, 22 Dec 2007 21:23:48 -0600 [thread overview]
Message-ID: <476DD4C4.5030708@freescale.com> (raw)
In-Reply-To: <75b66ecd0712202128n2f13adf2ie9a344e0c19d69ad@mail.gmail.com>
Lee Revell wrote:
> Please use DMA_32BIT_MASK (see include/linux/dma-mapping.h) instead of
> 0xffffffff.
No prob. But did you see this comment:
/*
* NOTE: do not use the below macros in new code and do not add new
definitions
* here.
*
* Instead, just open-code DMA_BIT_MASK(n) within your driver
*/
So I guess I should use DMA_BIT_MASK(32) instead.
> I've personally fixed a heisenbug in an ALSA driver
> caused by incorrectly typed DMA mask...
Can you explain to me what all of this does? Is it okay to use a static
u64 variable? Why do so many drivers do it that way? I don't even know
if 0xFFFFFFFF is the right number for my platform.
next prev parent reply other threads:[~2007-12-23 3:23 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 0:03 [PATCH] ASoC drivers for the Freescale MPC8610 SoC Timur Tabi
2007-12-20 4:06 ` Olof Johansson
2007-12-20 14:24 ` Timur Tabi
2007-12-20 13:54 ` Takashi Iwai
2007-12-20 13:54 ` [alsa-devel] " Takashi Iwai
2007-12-20 17:04 ` Timur Tabi
2007-12-20 17:04 ` [alsa-devel] " Timur Tabi
2007-12-21 5:28 ` Lee Revell
2007-12-21 5:28 ` [alsa-devel] " Lee Revell
2007-12-23 3:23 ` Timur Tabi [this message]
2007-12-23 3:23 ` Timur Tabi
2007-12-20 22:39 ` Olof Johansson
2007-12-20 22:37 ` Timur Tabi
2007-12-20 22:43 ` Scott Wood
2007-12-23 2:58 ` Timur Tabi
2008-01-02 18:08 ` Scott Wood
2007-12-20 14:47 ` Jon Loeliger
2007-12-20 22:29 ` Jon Smirl
2007-12-20 22:32 ` Timur Tabi
2007-12-20 22:38 ` Jon Smirl
2007-12-20 22:40 ` Timur Tabi
2007-12-20 22:44 ` Scott Wood
2007-12-20 23:13 ` Jon Smirl
2007-12-21 0:00 ` David Gibson
2008-01-01 17:25 ` Jon Smirl
2008-01-01 17:42 ` Jon Smirl
2008-01-02 15:19 ` Timur Tabi
2008-01-02 15:34 ` Jon Smirl
2008-01-03 17:54 ` Timur Tabi
2008-01-03 18:13 ` Grant Likely
2008-01-03 18:20 ` Timur Tabi
2008-01-03 18:32 ` Grant Likely
2008-01-03 23:51 ` David Gibson
2008-01-05 2:39 ` Timur Tabi
2008-01-05 2:39 ` [alsa-devel] " Timur Tabi
2008-01-06 0:46 ` David Gibson
2008-01-06 0:46 ` [alsa-devel] " David Gibson
2008-01-07 14:24 ` Mark Brown
2008-01-07 14:24 ` [alsa-devel] " Mark Brown
2008-01-07 15:52 ` Timur Tabi
2008-01-07 15:52 ` [alsa-devel] " Timur Tabi
2008-01-07 18:28 ` Mark Brown
2008-01-07 18:28 ` [alsa-devel] " Mark Brown
2008-01-10 3:49 ` David Gibson
2008-01-10 3:49 ` [alsa-devel] " David Gibson
2008-01-10 5:41 ` Jon Smirl
2008-01-10 5:41 ` [alsa-devel] " Jon Smirl
2008-01-10 10:30 ` Liam Girdwood
2008-01-10 10:30 ` [alsa-devel] " Liam Girdwood
2008-01-10 15:39 ` Timur Tabi
2008-01-10 15:39 ` [alsa-devel] " Timur Tabi
2008-01-10 16:01 ` Grant Likely
2008-01-10 16:01 ` [alsa-devel] " Grant Likely
2008-01-10 16:03 ` Timur Tabi
2008-01-10 16:03 ` [alsa-devel] " Timur Tabi
2008-01-10 20:10 ` Jon Smirl
2008-01-10 20:10 ` [alsa-devel] " Jon Smirl
2008-01-10 20:13 ` Timur Tabi
2008-01-10 20:13 ` [alsa-devel] " Timur Tabi
2008-01-10 20:24 ` Grant Likely
2008-01-10 20:24 ` [alsa-devel] " Grant Likely
2008-01-10 20:35 ` Timur Tabi
2008-01-10 20:35 ` [alsa-devel] " Timur Tabi
2008-01-10 20:39 ` Jon Smirl
2008-01-10 20:39 ` [alsa-devel] " Jon Smirl
2008-01-10 20:44 ` Timur Tabi
2008-01-10 20:44 ` [alsa-devel] " Timur Tabi
2008-01-07 18:44 ` Liam Girdwood
2008-01-07 18:44 ` [alsa-devel] " Liam Girdwood
2008-01-07 18:45 ` Timur Tabi
2008-01-07 18:45 ` [alsa-devel] " Timur Tabi
2008-01-02 16:12 ` Grant Likely
2008-01-03 18:08 ` Timur Tabi
2008-01-03 18:17 ` Grant Likely
2008-01-03 18:54 ` Scott Wood
2008-01-03 19:13 ` Grant Likely
2008-01-03 19:18 ` Scott Wood
2008-01-03 23:13 ` Mark Brown
2008-01-03 23:13 ` [alsa-devel] " Mark Brown
2008-01-05 2:35 ` Timur Tabi
2008-01-05 3:28 ` Grant Likely
2008-01-02 0:26 ` David Gibson
2008-01-02 15:10 ` Timur Tabi
2008-01-02 17:23 ` Mark Brown
2008-01-02 17:23 ` [alsa-devel] " Mark Brown
2008-01-03 18:23 ` Timur Tabi
2008-01-03 18:23 ` [alsa-devel] " Timur Tabi
2008-01-03 23:00 ` Mark Brown
2008-01-03 23:00 ` [alsa-devel] " Mark Brown
2008-01-05 2:43 ` Timur Tabi
2008-01-05 2:43 ` [alsa-devel] " Timur Tabi
2008-01-07 13:37 ` Mark Brown
2008-01-07 13:37 ` [alsa-devel] " Mark Brown
2008-01-02 4:27 ` Jon Smirl
2008-01-02 15:29 ` Timur Tabi
2008-01-02 15:56 ` Jon Smirl
2008-01-02 16:32 ` Grant Likely
2008-01-02 17:12 ` Jon Smirl
2008-01-02 17:22 ` Grant Likely
2008-01-02 18:43 ` Jon Smirl
2008-01-02 18:50 ` Grant Likely
2008-01-02 18:56 ` Jon Smirl
2008-01-03 4:46 ` David Gibson
2008-01-03 4:46 ` David Gibson
2008-01-03 14:33 ` Jon Smirl
2008-01-03 17:57 ` Timur Tabi
2008-01-02 16:28 ` Grant Likely
2008-01-02 18:49 ` Mark Brown
2008-01-02 18:49 ` [alsa-devel] " Mark Brown
2008-01-03 18:16 ` Timur Tabi
2008-01-03 18:16 ` [alsa-devel] " Timur Tabi
2008-01-03 23:47 ` David Gibson
2008-01-03 23:47 ` [alsa-devel] " David Gibson
2008-01-04 13:39 ` Mark Brown
2008-01-04 13:39 ` [alsa-devel] " Mark Brown
2008-01-03 18:14 ` Timur Tabi
2008-01-03 18:25 ` Grant Likely
2008-01-03 18:28 ` Timur Tabi
2008-01-03 18:38 ` Grant Likely
2008-01-03 4:44 ` David Gibson
2008-01-03 14:54 ` Jon Smirl
2008-01-04 5:01 ` David Gibson
2008-01-03 18:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476DD4C4.5030708@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=rlrevell@joe-job.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.