All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Dillow <dillowda@ornl.gov>,
	Guillaume Chazarain <guichaz@yahoo.fr>,
	linux-kernel@vger.kernel.org, linux-btrace@vger.kernel.org,
	mingo@redhat.com, tglx@linutronix.de
Subject: Re: CONFIG_NO_HZ breaks blktrace timestamps
Date: Fri, 11 Jan 2008 09:56:54 +0000	[thread overview]
Message-ID: <20080111095654.GR6258@kernel.dk> (raw)
In-Reply-To: <20080111094205.GE8143@elte.hu>

On Fri, Jan 11 2008, Ingo Molnar wrote:
> 
> * Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > > they are from the scheduler git tree (except the first debug patch), 
> > > but queued up for v2.6.25 at the moment.
> > 
> > So this means that blktrace will be broken with CONFIG_NO_HZ for 
> > 2.6.24? That's clearly a regression.
> 
> 64-bit CONFIG_NO_HZ is a new feature in v2.6.24. If it happens on 32-bit 
> too and it didnt happen in v2.6.23 32-bit then it's a regression.

If blktrace worked in 2.6.23 and it doesn't in 2.6.24 because of some
option that isn't immediately apparent, then it's a regression. Period.

> all this comes from blktrace's original decision of using sched_clock()
> :-) It's not a global timesource and it's not trivial to turn it into a
> halfways usable global timesource.

Hey, it was a high res time source and the only one easily available :)
I'm fine with using another timesource, I'll take suggestions or patches
any day!

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jens.axboe@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Dillow <dillowda@ornl.gov>,
	Guillaume Chazarain <guichaz@yahoo.fr>,
	linux-kernel@vger.kernel.org, linux-btrace@vger.kernel.org,
	mingo@redhat.com, tglx@linutronix.de
Subject: Re: CONFIG_NO_HZ breaks blktrace timestamps
Date: Fri, 11 Jan 2008 10:56:54 +0100	[thread overview]
Message-ID: <20080111095654.GR6258@kernel.dk> (raw)
In-Reply-To: <20080111094205.GE8143@elte.hu>

On Fri, Jan 11 2008, Ingo Molnar wrote:
> 
> * Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > > they are from the scheduler git tree (except the first debug patch), 
> > > but queued up for v2.6.25 at the moment.
> > 
> > So this means that blktrace will be broken with CONFIG_NO_HZ for 
> > 2.6.24? That's clearly a regression.
> 
> 64-bit CONFIG_NO_HZ is a new feature in v2.6.24. If it happens on 32-bit 
> too and it didnt happen in v2.6.23 32-bit then it's a regression.

If blktrace worked in 2.6.23 and it doesn't in 2.6.24 because of some
option that isn't immediately apparent, then it's a regression. Period.

> all this comes from blktrace's original decision of using sched_clock()
> :-) It's not a global timesource and it's not trivial to turn it into a
> halfways usable global timesource.

Hey, it was a high res time source and the only one easily available :)
I'm fine with using another timesource, I'll take suggestions or patches
any day!

-- 
Jens Axboe


  reply	other threads:[~2008-01-11  9:56 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 22:48 CONFIG_NO_HZ breaks blktrace timestamps David Dillow
2008-01-09 22:48 ` David Dillow
2008-01-10 20:25 ` David Dillow
2008-01-10 20:25   ` David Dillow
2008-01-10 22:44   ` Guillaume Chazarain
2008-01-10 22:44     ` Guillaume Chazarain
2008-01-11  3:04     ` David Dillow
2008-01-11  3:04       ` David Dillow
2008-01-11  9:07       ` Jens Axboe
2008-01-11  9:07         ` Jens Axboe
2008-01-11  9:23         ` Ingo Molnar
2008-01-11  9:23           ` Ingo Molnar
2008-01-11  9:25           ` Jens Axboe
2008-01-11  9:25             ` Jens Axboe
2008-01-11  9:42             ` Ingo Molnar
2008-01-11  9:42               ` Ingo Molnar
2008-01-11  9:56               ` Jens Axboe [this message]
2008-01-11  9:56                 ` Jens Axboe
2008-01-11 10:29                 ` [patch] block: fix " Ingo Molnar
2008-01-11 10:29                   ` Ingo Molnar
2008-01-11 10:47                   ` Guillaume Chazarain
2008-01-11 10:47                     ` Guillaume Chazarain
2008-01-11 10:50                     ` Ingo Molnar
2008-01-11 10:50                       ` Ingo Molnar
2008-01-11 12:28                   ` Jens Axboe
2008-01-11 12:28                     ` Jens Axboe
2008-01-11 12:42                     ` Jens Axboe
2008-01-11 12:42                       ` Jens Axboe
2008-01-11 13:21                     ` Ingo Molnar
2008-01-11 13:21                       ` Ingo Molnar
2008-01-11 17:18                       ` Jens Axboe
2008-01-11 17:18                         ` Jens Axboe
2008-01-14  7:51                         ` Ingo Molnar
2008-01-14  7:51                           ` Ingo Molnar
2008-01-14  7:59                           ` Ingo Molnar
2008-01-14  7:59                             ` Ingo Molnar
2008-01-14  8:10                             ` Jens Axboe
2008-01-14  8:10                               ` Jens Axboe
2008-01-14  8:39                           ` Christoph Hellwig
2008-01-14  8:42                             ` Jens Axboe
2008-01-14  8:42                               ` Jens Axboe
2008-01-11 15:36                   ` David Dillow
2008-01-11 15:36                     ` David Dillow
2008-01-11 16:44                     ` Ingo Molnar
2008-01-11 16:44                       ` Ingo Molnar
2008-01-11 17:26                       ` Jens Axboe
2008-01-11 17:26                         ` Jens Axboe
2008-01-11  9:29           ` CONFIG_NO_HZ breaks " Ingo Molnar
2008-01-11  9:29             ` Ingo Molnar
2008-01-11  9:34             ` Jens Axboe
2008-01-11  9:34               ` Jens Axboe
2008-01-11  9:28         ` nigel
2008-01-11  9:28           ` nigel
2008-01-11  9:32           ` Ingo Molnar
2008-01-11  9:32             ` Ingo Molnar
2008-01-13 22:54             ` nigel
2008-01-13 22:54               ` nigel
2008-01-11  9:44       ` Ingo Molnar
2008-01-11  9:44         ` Ingo Molnar
2008-01-11  9:51         ` Ingo Molnar
2008-01-11  9:51           ` Ingo Molnar
2008-01-11 10:41     ` Guillaume Chazarain
2008-01-11 10:41       ` Guillaume Chazarain
2008-01-11 10:55       ` Ingo Molnar
2008-01-11 10:55         ` Ingo Molnar
2008-01-11 22:30         ` Guillaume Chazarain
2008-01-11 22:30           ` Guillaume Chazarain
2008-01-12  0:03           ` Guillaume Chazarain
2008-01-12  0:03             ` Guillaume Chazarain
2008-01-11  9:34   ` Ingo Molnar
2008-01-11  9:34     ` Ingo Molnar
2008-01-11 15:43     ` David Dillow
2008-01-11 15:43       ` David Dillow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080111095654.GR6258@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=dillowda@ornl.gov \
    --cc=guichaz@yahoo.fr \
    --cc=linux-btrace@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.