From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
gregkh-l3A5Bk7waGM@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 6/6] spi : use class iteration api
Date: Mon, 21 Jan 2008 22:56:11 -0800 [thread overview]
Message-ID: <200801212256.11484.david-b@pacbell.net> (raw)
In-Reply-To: <20080122060331.GG3066-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
On Monday 21 January 2008, Dave Young wrote:
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = (u16 *)data;
That's "void *data" so "u16 *bus_num = data" is preferred.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 6/6] spi : use class iteration api
Date: Mon, 21 Jan 2008 22:56:11 -0800 [thread overview]
Message-ID: <200801212256.11484.david-b@pacbell.net> (raw)
In-Reply-To: <20080122060331.GG3066@darkstar.te-china.tietoenator.com>
On Monday 21 January 2008, Dave Young wrote:
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = (u16 *)data;
That's "void *data" so "u16 *bus_num = data" is preferred.
next prev parent reply other threads:[~2008-01-22 6:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 9:57 [PATCH 6/7] spi : use class iteration api Dave Young
2008-01-12 9:57 ` Dave Young
[not found] ` <20080112095711.GF2893-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-16 0:52 ` Dave Young
2008-01-16 0:52 ` Dave Young
2008-01-22 6:03 ` [PATCH 6/6] " Dave Young
2008-01-22 6:03 ` Dave Young
[not found] ` <20080122060331.GG3066-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-22 6:56 ` David Brownell [this message]
2008-01-22 6:56 ` David Brownell
[not found] ` <200801212256.11484.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-22 6:57 ` Dave Young
2008-01-22 6:57 ` Dave Young
2008-01-22 7:14 ` Dave Young
2008-01-22 7:14 ` Dave Young
[not found] ` <20080122071418.GA3725-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-22 7:41 ` David Brownell
2008-01-22 7:41 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801212256.11484.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.