* [PATCH 6/7] spi : use class iteration api
@ 2008-01-12 9:57 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-12 9:57 UTC (permalink / raw)
To: David Brownell
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-11 18:06:38.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-11 18:06:38.000000000 +0800
@@ -485,6 +485,17 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ if (m->bus_num == *bus_num)
+ return 1;
+ return 0;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +510,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 6/7] spi : use class iteration api
@ 2008-01-12 9:57 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-12 9:57 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, linux-kernel, spi-devel-general
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/spi/spi.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-11 18:06:38.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-11 18:06:38.000000000 +0800
@@ -485,6 +485,17 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ if (m->bus_num == *bus_num)
+ return 1;
+ return 0;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +510,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <20080112095711.GF2893-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 6/7] spi : use class iteration api
2008-01-12 9:57 ` Dave Young
@ 2008-01-16 0:52 ` Dave Young
-1 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-16 0:52 UTC (permalink / raw)
To: David Brownell
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Update the patch with minor return path changes in match function:
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/7] spi : use class iteration api
@ 2008-01-16 0:52 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-16 0:52 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, linux-kernel, spi-devel-general
Update the patch with minor return path changes in match function:
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 6/6] spi : use class iteration api
2008-01-12 9:57 ` Dave Young
@ 2008-01-22 6:03 ` Dave Young
-1 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 6:03 UTC (permalink / raw)
To: David Brownell
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 6/6] spi : use class iteration api
@ 2008-01-22 6:03 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 6:03 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, linux-kernel, spi-devel-general
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-16 08:43:35.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = (u16 *)data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <20080122060331.GG3066-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 6/6] spi : use class iteration api
2008-01-22 6:03 ` Dave Young
@ 2008-01-22 6:56 ` David Brownell
-1 siblings, 0 replies; 14+ messages in thread
From: David Brownell @ 2008-01-22 6:56 UTC (permalink / raw)
To: Dave Young
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Monday 21 January 2008, Dave Young wrote:
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = (u16 *)data;
That's "void *data" so "u16 *bus_num = data" is preferred.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] spi : use class iteration api
@ 2008-01-22 6:56 ` David Brownell
0 siblings, 0 replies; 14+ messages in thread
From: David Brownell @ 2008-01-22 6:56 UTC (permalink / raw)
To: Dave Young; +Cc: gregkh, linux-kernel, spi-devel-general
On Monday 21 January 2008, Dave Young wrote:
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = (u16 *)data;
That's "void *data" so "u16 *bus_num = data" is preferred.
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <200801212256.11484.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]
* Re: [PATCH 6/6] spi : use class iteration api
2008-01-22 6:56 ` David Brownell
@ 2008-01-22 6:57 ` Dave Young
-1 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 6:57 UTC (permalink / raw)
To: David Brownell
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Jan 22, 2008 2:56 PM, David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> On Monday 21 January 2008, Dave Young wrote:
> > +static int __spi_master_match(struct device *dev, void *data)
> > +{
> > +struct spi_master *m;
> > +u16 *bus_num = (u16 *)data;
>
> That's "void *data" so "u16 *bus_num = data" is preferred.
>
Fine.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] spi : use class iteration api
@ 2008-01-22 6:57 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 6:57 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, linux-kernel, spi-devel-general
On Jan 22, 2008 2:56 PM, David Brownell <david-b@pacbell.net> wrote:
> On Monday 21 January 2008, Dave Young wrote:
> > +static int __spi_master_match(struct device *dev, void *data)
> > +{
> > +struct spi_master *m;
> > +u16 *bus_num = (u16 *)data;
>
> That's "void *data" so "u16 *bus_num = data" is preferred.
>
Fine.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 6/6] spi : use class iteration api
2008-01-22 6:56 ` David Brownell
@ 2008-01-22 7:14 ` Dave Young
-1 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 7:14 UTC (permalink / raw)
To: David Brownell
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] spi : use class iteration api
@ 2008-01-22 7:14 ` Dave Young
0 siblings, 0 replies; 14+ messages in thread
From: Dave Young @ 2008-01-22 7:14 UTC (permalink / raw)
To: David Brownell; +Cc: gregkh, linux-kernel, spi-devel-general
Convert to use the class iteration api.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
drivers/spi/spi.c | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
+++ linux.new/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
@@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
}
EXPORT_SYMBOL_GPL(spi_unregister_master);
+static int __spi_master_match(struct device *dev, void *data)
+{
+ struct spi_master *m;
+ u16 *bus_num = data;
+
+ m = container_of(dev, struct spi_master, dev);
+ return m->bus_num == *bus_num;
+}
+
/**
* spi_busnum_to_master - look up master associated with bus_num
* @bus_num: the master's bus number
@@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
{
struct device *dev;
struct spi_master *master = NULL;
- struct spi_master *m;
- down(&spi_master_class.sem);
- list_for_each_entry(dev, &spi_master_class.children, node) {
- m = container_of(dev, struct spi_master, dev);
- if (m->bus_num == bus_num) {
- master = spi_master_get(m);
- break;
- }
- }
- up(&spi_master_class.sem);
+ dev = class_find_device(&spi_master_class, &bus_num,
+ __spi_master_match);
+ if (dev)
+ master = container_of(dev, struct spi_master, dev);
+ /* reference got in class_find_device */
return master;
}
EXPORT_SYMBOL_GPL(spi_busnum_to_master);
^ permalink raw reply [flat|nested] 14+ messages in thread[parent not found: <20080122071418.GA3725-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 6/6] spi : use class iteration api
2008-01-22 7:14 ` Dave Young
@ 2008-01-22 7:41 ` David Brownell
-1 siblings, 0 replies; 14+ messages in thread
From: David Brownell @ 2008-01-22 7:41 UTC (permalink / raw)
To: Dave Young
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
gregkh-l3A5Bk7waGM, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Monday 21 January 2008, Dave Young wrote:
> Convert to use the class iteration api.
>
> Signed-off-by: Dave Young <hidave.darkstar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Ack.
> ---
> drivers/spi/spi.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
> --- linux/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
> +++ linux.new/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
> @@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
> }
> EXPORT_SYMBOL_GPL(spi_unregister_master);
>
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = data;
> +
> + m = container_of(dev, struct spi_master, dev);
> + return m->bus_num == *bus_num;
> +}
> +
> /**
> * spi_busnum_to_master - look up master associated with bus_num
> * @bus_num: the master's bus number
> @@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
> {
> struct device *dev;
> struct spi_master *master = NULL;
> - struct spi_master *m;
>
> - down(&spi_master_class.sem);
> - list_for_each_entry(dev, &spi_master_class.children, node) {
> - m = container_of(dev, struct spi_master, dev);
> - if (m->bus_num == bus_num) {
> - master = spi_master_get(m);
> - break;
> - }
> - }
> - up(&spi_master_class.sem);
> + dev = class_find_device(&spi_master_class, &bus_num,
> + __spi_master_match);
> + if (dev)
> + master = container_of(dev, struct spi_master, dev);
> + /* reference got in class_find_device */
> return master;
> }
> EXPORT_SYMBOL_GPL(spi_busnum_to_master);
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] spi : use class iteration api
@ 2008-01-22 7:41 ` David Brownell
0 siblings, 0 replies; 14+ messages in thread
From: David Brownell @ 2008-01-22 7:41 UTC (permalink / raw)
To: Dave Young; +Cc: gregkh, linux-kernel, spi-devel-general
On Monday 21 January 2008, Dave Young wrote:
> Convert to use the class iteration api.
>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Ack.
> ---
> drivers/spi/spi.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
> --- linux/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
> +++ linux.new/drivers/spi/spi.c 2008-01-22 15:09:49.000000000 +0800
> @@ -485,6 +485,15 @@ void spi_unregister_master(struct spi_ma
> }
> EXPORT_SYMBOL_GPL(spi_unregister_master);
>
> +static int __spi_master_match(struct device *dev, void *data)
> +{
> + struct spi_master *m;
> + u16 *bus_num = data;
> +
> + m = container_of(dev, struct spi_master, dev);
> + return m->bus_num == *bus_num;
> +}
> +
> /**
> * spi_busnum_to_master - look up master associated with bus_num
> * @bus_num: the master's bus number
> @@ -499,17 +508,12 @@ struct spi_master *spi_busnum_to_master(
> {
> struct device *dev;
> struct spi_master *master = NULL;
> - struct spi_master *m;
>
> - down(&spi_master_class.sem);
> - list_for_each_entry(dev, &spi_master_class.children, node) {
> - m = container_of(dev, struct spi_master, dev);
> - if (m->bus_num == bus_num) {
> - master = spi_master_get(m);
> - break;
> - }
> - }
> - up(&spi_master_class.sem);
> + dev = class_find_device(&spi_master_class, &bus_num,
> + __spi_master_match);
> + if (dev)
> + master = container_of(dev, struct spi_master, dev);
> + /* reference got in class_find_device */
> return master;
> }
> EXPORT_SYMBOL_GPL(spi_busnum_to_master);
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2008-01-22 7:42 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-12 9:57 [PATCH 6/7] spi : use class iteration api Dave Young
2008-01-12 9:57 ` Dave Young
[not found] ` <20080112095711.GF2893-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-16 0:52 ` Dave Young
2008-01-16 0:52 ` Dave Young
2008-01-22 6:03 ` [PATCH 6/6] " Dave Young
2008-01-22 6:03 ` Dave Young
[not found] ` <20080122060331.GG3066-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-22 6:56 ` David Brownell
2008-01-22 6:56 ` David Brownell
[not found] ` <200801212256.11484.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-22 6:57 ` Dave Young
2008-01-22 6:57 ` Dave Young
2008-01-22 7:14 ` Dave Young
2008-01-22 7:14 ` Dave Young
[not found] ` <20080122071418.GA3725-4/PLUo9XfK+r2/o/tYUWRb82SWQ1Dih0B/ovq0HbDYUAvxtiuMwx3w@public.gmane.org>
2008-01-22 7:41 ` David Brownell
2008-01-22 7:41 ` David Brownell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.