From: Paul Mundt <lethal@linux-sh.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: add support for SPI over SuperH SCI pins
Date: Tue, 22 Jan 2008 03:11:14 +0000 [thread overview]
Message-ID: <20080122031114.GA2062@linux-sh.org> (raw)
In-Reply-To: <200801211429.29906.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Mon, Jan 21, 2008 at 02:29:29PM -0800, David Brownell wrote:
> On Monday 21 January 2008, Magnus Damm wrote:
> > +struct sh_sci_spi {
> > + struct spi_bitbang bitbang;
> > +
> > + unsigned long mapbase;
>
> Not "void __iomem *mapbase"?
>
> I notice that you're not doing an ioremap() to get this address.
> Is the platform device properly registering a *physical* address
> in the IORESOURCE_MEM record for the device?
>
It should be ioremap(), yes. While for these parts ioremap() doesn't
really do anything, it still takes care of the void __iomem * casting
properly, and there are in fact parts where we have no choice but to go
through page tables anyways.
> > +#define spidelay(x) ndelay(x)
> > +
> > +#define EXPAND_BITBANG_TXRX
> > +#include <linux/spi/spi_bitbang.h>
> > +
This is rather unorthodox..
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] spi: add support for SPI over SuperH SCI pins
Date: Tue, 22 Jan 2008 12:11:14 +0900 [thread overview]
Message-ID: <20080122031114.GA2062@linux-sh.org> (raw)
In-Reply-To: <200801211429.29906.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Mon, Jan 21, 2008 at 02:29:29PM -0800, David Brownell wrote:
> On Monday 21 January 2008, Magnus Damm wrote:
> > +struct sh_sci_spi {
> > + struct spi_bitbang bitbang;
> > +
> > + unsigned long mapbase;
>
> Not "void __iomem *mapbase"?
>
> I notice that you're not doing an ioremap() to get this address.
> Is the platform device properly registering a *physical* address
> in the IORESOURCE_MEM record for the device?
>
It should be ioremap(), yes. While for these parts ioremap() doesn't
really do anything, it still takes care of the void __iomem * casting
properly, and there are in fact parts where we have no choice but to go
through page tables anyways.
> > +#define spidelay(x) ndelay(x)
> > +
> > +#define EXPAND_BITBANG_TXRX
> > +#include <linux/spi/spi_bitbang.h>
> > +
This is rather unorthodox..
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-01-22 3:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 10:49 [PATCH] spi: add support for SPI over SuperH SCI pins Magnus Damm
2008-01-21 10:49 ` Magnus Damm
[not found] ` <20080121104913.11908.50319.sendpatchset-oNevn9JCO/nrQWrVbqIkupgxem/jg0Vn@public.gmane.org>
2008-01-21 22:29 ` David Brownell
2008-01-21 22:29 ` David Brownell
[not found] ` <200801211429.29906.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-22 3:11 ` Paul Mundt [this message]
2008-01-22 3:11 ` Paul Mundt
[not found] ` <20080122031114.GA2062-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2008-01-22 4:22 ` David Brownell
2008-01-22 4:22 ` David Brownell
[not found] ` <200801212022.23139.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-01-22 5:26 ` [spi-devel-general] " David Brownell
2008-01-22 5:26 ` David Brownell
2008-01-22 6:03 ` Paul Mundt
2008-01-22 6:03 ` Paul Mundt
2008-01-22 3:56 ` Magnus Damm
2008-01-22 3:56 ` Magnus Damm
2008-01-22 4:38 ` David Brownell
2008-01-22 4:38 ` David Brownell
2008-01-23 4:14 ` [PATCH] spi: add support for SPI over SuperH SCI pins V2 Magnus Damm
2008-01-23 4:14 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080122031114.GA2062@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.