Re: [PATCH] Don't abort if prefix is not set

[Robert Millan <rmh@aybabtu.com>]

On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote:
> Quoting Robert Millan <rmh@aybabtu.com>:
> 
> >>+  if (! grub_dl_dir) {
> >>+    grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set");
> >>+    return 0;
> >
> >Seems fine, but are you sure this error is handled somewhere?
> 
> If prefix is not set, the module is not loaded.  What other handling  
> do we need?

What I mean is, is the error message printed?  I recall it had to be handled
somewhere.  Or maybe I'm confused...

> I found that prefix would not be set on PowerPC if /memory/available  
> is missing.

Sounds strange.. how is that so?

> Even though I have a better workaround for it now, I  
> still think that aborting for such minor reason is wrong.  After all,  
> the user may unset prefix.

Agreed..

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)