From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Don't abort if prefix is not set
Date: Sat, 26 Jan 2008 22:35:31 +0200 [thread overview]
Message-ID: <479B9993.3080405@nic.fi> (raw)
In-Reply-To: <20080126202457.GA7323@thorin>
Robert Millan wrote:
> On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote:
>> Quoting Robert Millan <rmh@aybabtu.com>:
>>
>>>> + if (! grub_dl_dir) {
>>>> + grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set");
>>>> + return 0;
>>> Seems fine, but are you sure this error is handled somewhere?
>> If prefix is not set, the module is not loaded. What other handling
>> do we need?
>
> What I mean is, is the error message printed? I recall it had to be handled
> somewhere. Or maybe I'm confused...
Whole error stack is printed just before prompt.
prev parent reply other threads:[~2008-01-26 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 19:44 [PATCH] Don't abort if prefix is not set Pavel Roskin
2008-01-26 19:59 ` Robert Millan
2008-01-26 20:11 ` Pavel Roskin
2008-01-26 20:24 ` Robert Millan
2008-01-26 20:31 ` Pavel Roskin
2008-01-27 8:36 ` Robert Millan
2008-01-26 20:35 ` Vesa Jääskeläinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479B9993.3080405@nic.fi \
--to=chaac@nic.fi \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.