From: Scott Wood <scottwood@freescale.com>
To: Doug Maxey <dwm@austin.ibm.com>
Cc: Linux PowerPC List <linuxppc-dev@ozlabs.org>,
Jan-Bernd Themann <themann@de.ibm.com>,
Jeff Garzik <jgarzik@garzik.org>,
Paul Mackerras <paulus@samba.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints
Date: Fri, 1 Feb 2008 13:23:45 -0600 [thread overview]
Message-ID: <20080201192344.GA4541@loki.buserror.net> (raw)
In-Reply-To: <1201832451-23634-5-git-send-email-dwm@austin.ibm.com>
On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:
> /* input param R5 */
> -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
> -#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12)
> -#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15)
> -#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
> -#define H_ALL_RES_QP_LL_QP EHEA_BMASK_IBM(17, 17)
> -#define H_ALL_RES_QP_DMA128 EHEA_BMASK_IBM(19, 19)
> -#define H_ALL_RES_QP_HSM EHEA_BMASK_IBM(20, 21)
> -#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
> -#define H_ALL_RES_QP_TENURE EHEA_BMASK_IBM(48, 55)
> -#define H_ALL_RES_QP_RES_TYP EHEA_BMASK_IBM(56, 63)
> +#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
> +#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12)
> +#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15)
> +#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
> +#define H_ALL_RES_QP_LL_QP EHEA_BMASK_IBM(17, 17)
> +#define H_ALL_RES_QP_DMA128 EHEA_BMASK_IBM(19, 19)
> +#define H_ALL_RES_QP_HSM EHEA_BMASK_IBM(20, 21)
> +#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
> +#define H_ALL_RES_QP_TENURE EHEA_BMASK_IBM(48, 55)
> +#define H_ALL_RES_QP_RES_TYP EHEA_BMASK_IBM(56, 63)
This was better the way it was (before, it was readable at any tab setting);
checkpatch is overeager to complain on tab/space issues (it's a bit hard to
distinguish indentation from alignment with a regex).
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Doug Maxey <dwm@austin.ibm.com>
Cc: Jeff Garzik <jgarzik@garzik.org>,
Linux PowerPC List <linuxppc-dev@ozlabs.org>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Jan-Bernd Themann <themann@de.ibm.com>
Subject: Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints
Date: Fri, 1 Feb 2008 13:23:45 -0600 [thread overview]
Message-ID: <20080201192344.GA4541@loki.buserror.net> (raw)
In-Reply-To: <1201832451-23634-5-git-send-email-dwm@austin.ibm.com>
On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote:
> /* input param R5 */
> -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
> -#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12)
> -#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15)
> -#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
> -#define H_ALL_RES_QP_LL_QP EHEA_BMASK_IBM(17, 17)
> -#define H_ALL_RES_QP_DMA128 EHEA_BMASK_IBM(19, 19)
> -#define H_ALL_RES_QP_HSM EHEA_BMASK_IBM(20, 21)
> -#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
> -#define H_ALL_RES_QP_TENURE EHEA_BMASK_IBM(48, 55)
> -#define H_ALL_RES_QP_RES_TYP EHEA_BMASK_IBM(56, 63)
> +#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11)
> +#define H_ALL_RES_QP_QPP EHEA_BMASK_IBM(12, 12)
> +#define H_ALL_RES_QP_RQR EHEA_BMASK_IBM(13, 15)
> +#define H_ALL_RES_QP_EQEG EHEA_BMASK_IBM(16, 16)
> +#define H_ALL_RES_QP_LL_QP EHEA_BMASK_IBM(17, 17)
> +#define H_ALL_RES_QP_DMA128 EHEA_BMASK_IBM(19, 19)
> +#define H_ALL_RES_QP_HSM EHEA_BMASK_IBM(20, 21)
> +#define H_ALL_RES_QP_SIGT EHEA_BMASK_IBM(22, 23)
> +#define H_ALL_RES_QP_TENURE EHEA_BMASK_IBM(48, 55)
> +#define H_ALL_RES_QP_RES_TYP EHEA_BMASK_IBM(56, 63)
This was better the way it was (before, it was readable at any tab setting);
checkpatch is overeager to complain on tab/space issues (it's a bit hard to
distinguish indentation from alignment with a regex).
-Scott
next prev parent reply other threads:[~2008-02-01 19:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 2:20 [PATCH 0/5] ehea checkpatch fixups Doug Maxey
2008-02-01 2:20 ` [PATCH 1/5] ehea: fix ehea.h checkpatch complaints Doug Maxey
2008-02-01 18:40 ` Jeff Garzik
2008-02-01 18:40 ` Jeff Garzik
2008-02-01 18:43 ` Jeff Garzik
2008-02-01 18:43 ` Jeff Garzik
2008-02-01 2:20 ` [PATCH 2/5] ehea: fix ethtool " Doug Maxey
2008-02-01 2:20 ` [PATCH 3/5] ehea: fix main " Doug Maxey
2008-02-01 2:20 ` [PATCH 4/5] ehea: fix phyp " Doug Maxey
2008-02-01 19:23 ` Scott Wood [this message]
2008-02-01 19:23 ` Scott Wood
2008-02-02 4:39 ` Doug Maxey
2008-02-02 4:39 ` Doug Maxey
2008-02-04 18:06 ` Scott Wood
2008-02-01 2:20 ` [PATCH 5/5] ehea: fix qmr " Doug Maxey
2008-02-01 3:05 ` [PATCH 0/5] ehea checkpatch fixups Nathan Lynch
2008-02-01 3:05 ` Nathan Lynch
2008-02-01 4:35 ` Doug Maxey
2008-02-01 4:35 ` Doug Maxey
-- strict thread matches above, loose matches on Subject: below --
2008-01-29 6:50 [PATCH 0/5] ehea: fixups for checkpatch Doug Maxey
2008-01-29 6:50 ` [PATCH 4/5] ehea: fix phyp checkpatch complaints Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201192344.GA4541@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=dwm@austin.ibm.com \
--cc=jgarzik@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.