All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Maxey <dwm@enoyolf.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: Jan-Bernd Themann <themann@de.ibm.com>,
	netdev@vger.kernel.org, Jeff Garzik <jgarzik@garzik.org>,
	Linux PowerPC List <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 0/5] ehea checkpatch fixups
Date: Thu, 31 Jan 2008 22:35:18 -0600	[thread overview]
Message-ID: <472.1201840518@bebe.enoyolf.org> (raw)
In-Reply-To: <20080201030542.GX14201@localdomain>


On Thu, 31 Jan 2008 21:05:42 CST, Nathan Lynch wrote:
> Doug Maxey wrote:
> > 
> > A small set of fixups for checkpatch.
> > 
> > Based on upstream pull from a few hours ago.
> 
> Er, ehea doesn't even build right now[1], maybe that could get fixed
> first?  :-)
> 
> [1] http://lkml.org/lkml/2008/1/28/337

For sure these won't break it any worse.  ;)  Think of these more as a 
janitorial thing vs. structural.

Doesn't gregkh's patch work?  At least for the interim?

Jan-Bernd,
What tools are looking in sysfs? distro scripts?  I don't see any link 
between ethtool and the driver (other than the driver internal bits).
Am I missing something obvious?

++doug

WARNING: multiple messages have this Message-ID (diff)
From: Doug Maxey <dwm@enoyolf.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: Doug Maxey <dwm@austin.ibm.com>, Jeff Garzik <jgarzik@garzik.org>,
	Linux PowerPC List <linuxppc-dev@ozlabs.org>,
	netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Jan-Bernd Themann <themann@de.ibm.com>
Subject: Re: [PATCH 0/5] ehea checkpatch fixups
Date: Thu, 31 Jan 2008 22:35:18 -0600	[thread overview]
Message-ID: <472.1201840518@bebe.enoyolf.org> (raw)
In-Reply-To: <20080201030542.GX14201@localdomain>


On Thu, 31 Jan 2008 21:05:42 CST, Nathan Lynch wrote:
> Doug Maxey wrote:
> > 
> > A small set of fixups for checkpatch.
> > 
> > Based on upstream pull from a few hours ago.
> 
> Er, ehea doesn't even build right now[1], maybe that could get fixed
> first?  :-)
> 
> [1] http://lkml.org/lkml/2008/1/28/337

For sure these won't break it any worse.  ;)  Think of these more as a 
janitorial thing vs. structural.

Doesn't gregkh's patch work?  At least for the interim?

Jan-Bernd,
What tools are looking in sysfs? distro scripts?  I don't see any link 
between ethtool and the driver (other than the driver internal bits).
Am I missing something obvious?

++doug





  reply	other threads:[~2008-02-01  5:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01  2:20 [PATCH 0/5] ehea checkpatch fixups Doug Maxey
2008-02-01  2:20 ` [PATCH 1/5] ehea: fix ehea.h checkpatch complaints Doug Maxey
2008-02-01 18:40   ` Jeff Garzik
2008-02-01 18:40     ` Jeff Garzik
2008-02-01 18:43     ` Jeff Garzik
2008-02-01 18:43       ` Jeff Garzik
2008-02-01  2:20 ` [PATCH 2/5] ehea: fix ethtool " Doug Maxey
2008-02-01  2:20 ` [PATCH 3/5] ehea: fix main " Doug Maxey
2008-02-01  2:20 ` [PATCH 4/5] ehea: fix phyp " Doug Maxey
2008-02-01 19:23   ` Scott Wood
2008-02-01 19:23     ` Scott Wood
2008-02-02  4:39     ` Doug Maxey
2008-02-02  4:39       ` Doug Maxey
2008-02-04 18:06       ` Scott Wood
2008-02-01  2:20 ` [PATCH 5/5] ehea: fix qmr " Doug Maxey
2008-02-01  3:05 ` [PATCH 0/5] ehea checkpatch fixups Nathan Lynch
2008-02-01  3:05   ` Nathan Lynch
2008-02-01  4:35   ` Doug Maxey [this message]
2008-02-01  4:35     ` Doug Maxey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472.1201840518@bebe.enoyolf.org \
    --to=dwm@enoyolf.org \
    --cc=jgarzik@garzik.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=ntl@pobox.com \
    --cc=paulus@samba.org \
    --cc=themann@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.