From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Move os dependent code to a separate file ?
Date: Sat, 2 Feb 2008 17:43:26 +0100 [thread overview]
Message-ID: <20080202164326.GD24700@thorin> (raw)
In-Reply-To: <ca0f59980802020629j501bf865l3065087545e73c66@mail.gmail.com>
On Sat, Feb 02, 2008 at 10:29:20PM +0800, Bean wrote:
> Hi,
>
> i can see that there are linux specific code in util/biosdisk.c,
> perhaps we should move them to a separate file such as util/osdep.c ?
In general I don't like very much to split unportable code in separate files
because it's easy to lose context of what it is doing. But some Linux-specific
code in that file is obsolete, IIRC, inherited from GRUB Legacy just to support
ancient libcs. Maybe part of it needs to be considered for removal.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2008-02-02 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 14:29 Move os dependent code to a separate file ? Bean
2008-02-02 16:43 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080202164326.GD24700@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.