* Move os dependent code to a separate file ?
@ 2008-02-02 14:29 Bean
2008-02-02 16:43 ` Robert Millan
0 siblings, 1 reply; 2+ messages in thread
From: Bean @ 2008-02-02 14:29 UTC (permalink / raw)
To: The development of GRUB 2
Hi,
i can see that there are linux specific code in util/biosdisk.c,
perhaps we should move them to a separate file such as util/osdep.c ?
--
Bean
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Move os dependent code to a separate file ?
2008-02-02 14:29 Move os dependent code to a separate file ? Bean
@ 2008-02-02 16:43 ` Robert Millan
0 siblings, 0 replies; 2+ messages in thread
From: Robert Millan @ 2008-02-02 16:43 UTC (permalink / raw)
To: The development of GRUB 2
On Sat, Feb 02, 2008 at 10:29:20PM +0800, Bean wrote:
> Hi,
>
> i can see that there are linux specific code in util/biosdisk.c,
> perhaps we should move them to a separate file such as util/osdep.c ?
In general I don't like very much to split unportable code in separate files
because it's easy to lose context of what it is doing. But some Linux-specific
code in that file is obsolete, IIRC, inherited from GRUB Legacy just to support
ancient libcs. Maybe part of it needs to be considered for removal.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-02 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02 14:29 Move os dependent code to a separate file ? Bean
2008-02-02 16:43 ` Robert Millan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.