All of lore.kernel.org
 help / color / mirror / Atom feed
From: Soren Hansen <soren-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
To: qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual	Machine interface (v2)
Date: Mon, 4 Feb 2008 14:51:49 +0100	[thread overview]
Message-ID: <20080204135149.GD4554@butch.linux2go.dk> (raw)
In-Reply-To: <1201903921-1125-7-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1458 bytes --]

On Fri, Feb 01, 2008 at 04:12:01PM -0600, Anthony Liguori wrote:
> Index: qemu/hw/vga_int.h
> ===================================================================
> --- qemu.orig/hw/vga_int.h	2008-02-01 15:23:45.000000000 -0600
> +++ qemu/hw/vga_int.h	2008-02-01 15:29:04.000000000 -0600
> @@ -145,11 +145,20 @@
>      void (*cursor_draw_line)(struct VGAState *s, uint8_t *d, int y);    \
>      /* tell for each page if it has been updated since the last time */ \
>      uint32_t last_palette[256];                                         \
> -    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */
> +    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */	\
> +    unsigned long map_addr;						\
> +    unsigned long map_end;
>  
>  
>  typedef struct VGAState {
>      VGA_STATE_COMMON
> +
> +    int32_t  aliases_enabled;
> +    int32_t  pad1;
> +    uint32_t aliased_bank_base[2];
> +    uint32_t aliased_bank_limit[2];
> +
> +

These need to move into VGA_STATE_COMMON instead. Otherwise vmware_vga
will get confoozled becuase it relies on vga.c for its vesa
implementation. The patch is at:

	http://people.ubuntu.com/~soren/0001-Move-common-VGAState-attributes-to-VGA_STATE_COMMON.patch

/me grumbles about sourceforge's mailing list archive thing completely
messing up the formatting of patches...

-- 
Soren Hansen
Virtualisation specialist
Ubuntu Server Team
http://www.ubuntu.com/

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

WARNING: multiple messages have this Message-ID (diff)
From: Soren Hansen <soren@ubuntu.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [Qemu-devel] [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2)
Date: Mon, 4 Feb 2008 14:51:49 +0100	[thread overview]
Message-ID: <20080204135149.GD4554@butch.linux2go.dk> (raw)
In-Reply-To: <1201903921-1125-7-git-send-email-aliguori@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On Fri, Feb 01, 2008 at 04:12:01PM -0600, Anthony Liguori wrote:
> Index: qemu/hw/vga_int.h
> ===================================================================
> --- qemu.orig/hw/vga_int.h	2008-02-01 15:23:45.000000000 -0600
> +++ qemu/hw/vga_int.h	2008-02-01 15:29:04.000000000 -0600
> @@ -145,11 +145,20 @@
>      void (*cursor_draw_line)(struct VGAState *s, uint8_t *d, int y);    \
>      /* tell for each page if it has been updated since the last time */ \
>      uint32_t last_palette[256];                                         \
> -    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */
> +    uint32_t last_ch_attr[CH_ATTR_SIZE]; /* XXX: make it dynamic */	\
> +    unsigned long map_addr;						\
> +    unsigned long map_end;
>  
>  
>  typedef struct VGAState {
>      VGA_STATE_COMMON
> +
> +    int32_t  aliases_enabled;
> +    int32_t  pad1;
> +    uint32_t aliased_bank_base[2];
> +    uint32_t aliased_bank_limit[2];
> +
> +

These need to move into VGA_STATE_COMMON instead. Otherwise vmware_vga
will get confoozled becuase it relies on vga.c for its vesa
implementation. The patch is at:

	http://people.ubuntu.com/~soren/0001-Move-common-VGAState-attributes-to-VGA_STATE_COMMON.patch

/me grumbles about sourceforge's mailing list archive thing completely
messing up the formatting of patches...

-- 
Soren Hansen
Virtualisation specialist
Ubuntu Server Team
http://www.ubuntu.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2008-02-04 13:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 22:11 [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
     [not found] ` <1201903921-1125-1-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:11   ` [PATCH 1/6] Fix VMware VGA init call Anthony Liguori
2008-02-01 22:11     ` [Qemu-devel] " Anthony Liguori
     [not found]     ` <1201903921-1125-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:23       ` Anthony Liguori
2008-02-01 22:23         ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:11   ` [PATCH 2/6] Use correct types to enable > 2G support (v2) Anthony Liguori
2008-02-01 22:11     ` [Qemu-devel] " Anthony Liguori
     [not found]     ` <1201903921-1125-3-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04  1:56       ` Anthony Liguori
2008-02-04  1:56         ` [Qemu-devel] " Anthony Liguori
     [not found]         ` <47A670B4.6020803-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-02-04  8:45           ` Izik Eidus
2008-02-04  8:45             ` [Qemu-devel] " Izik Eidus
     [not found]             ` <1202114748.30861.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-04 15:31               ` Anthony Liguori
2008-02-04 15:31                 ` [Qemu-devel] " Anthony Liguori
2008-02-10 10:48             ` Avi Kivity
2008-02-10 10:48               ` [Qemu-devel] " Avi Kivity
2008-02-10 14:12               ` Paul Brook
2008-02-10 14:12                 ` Paul Brook
2008-02-10 14:55                 ` Avi Kivity
2008-02-10 14:55                   ` Avi Kivity
2008-02-10 14:59                   ` Paul Brook
2008-02-10 14:59                     ` Paul Brook
2008-02-10 15:14                     ` Avi Kivity
2008-02-10 15:14                       ` Avi Kivity
2008-02-01 22:11   ` [PATCH 3/6] SCI fixes (v2) Anthony Liguori
2008-02-01 22:11     ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:12   ` [PATCH 5/6] Tell BIOS about the number of CPUs (v2) Anthony Liguori
2008-02-01 22:12     ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:12   ` [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:12     ` [Qemu-devel] " Anthony Liguori
     [not found]     ` <1201903921-1125-7-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04 13:51       ` Soren Hansen [this message]
2008-02-04 13:51         ` Soren Hansen
     [not found]         ` <20080204135149.GD4554-w/BXfMF2+jKSwEwcaNC2fFpr/1R2p/CL@public.gmane.org>
2008-02-04 15:14           ` Anthony Liguori
2008-02-04 15:14             ` [kvm-devel] " Anthony Liguori
2008-02-01 22:11 ` [PATCH 4/6] Fix daemonize options (v2) Anthony Liguori
2008-02-01 22:11   ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080204135149.GD4554@butch.linux2go.dk \
    --to=soren-gewih/nmzzlqt0dzr+alfa@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.