From: Avi Kivity <avi@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Sun, 10 Feb 2008 16:55:08 +0200 [thread overview]
Message-ID: <47AF104C.3060401@qumranet.com> (raw)
In-Reply-To: <200802101412.27850.paul@codesourcery.com>
Paul Brook wrote:
>>> as far as i remember it was used to address something with
>>> cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
>>> or ~TARGET_PAGE_SIZE,
>>>
>>> the fact is that i dont know if it ever fixed anything
>>>
>> It fixes TARGET_PAGE_MASK, defined one line downscreen.
>>
>
> That doesn't really answer the question. What was wrong with the original
> definition?
>
There are many instances of ((physical address) & TARGET_PAGE_MASK)
scattered throughout the code. With 64-bit physical addresses, this
causes truncation.
Are suggesting to fix TARGET_PAGE_MASK directly? I think fixing
TARGET_PAGE_SIZE is better as everything else is defined in terms of it.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Izik Eidus <izike@qumranet.com>,
kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] Use correct types to enable > 2G support (v2)
Date: Sun, 10 Feb 2008 16:55:08 +0200 [thread overview]
Message-ID: <47AF104C.3060401@qumranet.com> (raw)
In-Reply-To: <200802101412.27850.paul@codesourcery.com>
Paul Brook wrote:
>>> as far as i remember it was used to address something with
>>> cpu_physical_memory_rw() probably related to &TARGET_PAGE_SIZE
>>> or ~TARGET_PAGE_SIZE,
>>>
>>> the fact is that i dont know if it ever fixed anything
>>>
>> It fixes TARGET_PAGE_MASK, defined one line downscreen.
>>
>
> That doesn't really answer the question. What was wrong with the original
> definition?
>
There are many instances of ((physical address) & TARGET_PAGE_MASK)
scattered throughout the code. With 64-bit physical addresses, this
causes truncation.
Are suggesting to fix TARGET_PAGE_MASK directly? I think fixing
TARGET_PAGE_SIZE is better as everything else is defined in terms of it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-02-10 14:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 22:11 [PATCH 0/6] Support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
[not found] ` <1201903921-1125-1-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:11 ` [PATCH 1/6] Fix VMware VGA init call Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
[not found] ` <1201903921-1125-2-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-01 22:23 ` Anthony Liguori
2008-02-01 22:23 ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:11 ` [PATCH 2/6] Use correct types to enable > 2G support (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
[not found] ` <1201903921-1125-3-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04 1:56 ` Anthony Liguori
2008-02-04 1:56 ` [Qemu-devel] " Anthony Liguori
[not found] ` <47A670B4.6020803-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-02-04 8:45 ` Izik Eidus
2008-02-04 8:45 ` [Qemu-devel] " Izik Eidus
[not found] ` <1202114748.30861.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-02-04 15:31 ` Anthony Liguori
2008-02-04 15:31 ` [Qemu-devel] " Anthony Liguori
2008-02-10 10:48 ` Avi Kivity
2008-02-10 10:48 ` [Qemu-devel] " Avi Kivity
2008-02-10 14:12 ` Paul Brook
2008-02-10 14:12 ` Paul Brook
2008-02-10 14:55 ` Avi Kivity [this message]
2008-02-10 14:55 ` Avi Kivity
2008-02-10 14:59 ` Paul Brook
2008-02-10 14:59 ` Paul Brook
2008-02-10 15:14 ` Avi Kivity
2008-02-10 15:14 ` Avi Kivity
2008-02-01 22:11 ` [PATCH 3/6] SCI fixes (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:12 ` [PATCH 5/6] Tell BIOS about the number of CPUs (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] " Anthony Liguori
2008-02-01 22:12 ` [PATCH 6/6] QEMU support for the Kernel Virtual Machine interface (v2) Anthony Liguori
2008-02-01 22:12 ` [Qemu-devel] " Anthony Liguori
[not found] ` <1201903921-1125-7-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-02-04 13:51 ` Soren Hansen
2008-02-04 13:51 ` Soren Hansen
[not found] ` <20080204135149.GD4554-w/BXfMF2+jKSwEwcaNC2fFpr/1R2p/CL@public.gmane.org>
2008-02-04 15:14 ` Anthony Liguori
2008-02-04 15:14 ` [kvm-devel] " Anthony Liguori
2008-02-01 22:11 ` [PATCH 4/6] Fix daemonize options (v2) Anthony Liguori
2008-02-01 22:11 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47AF104C.3060401@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.