From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection
Date: Wed, 6 Feb 2008 01:24:39 +0100 [thread overview]
Message-ID: <20080206002439.GC2704@thorin> (raw)
In-Reply-To: <47A8EB0D.6070103@t-online.de>
Hi Christian,
On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote:
> Two issues found in current CVS:
>
> 1. Booting a grub2-mkrescue floppy crashes if
> "(memdisk)/boot/grub/grub.cfg" does not exist. This is because
> grub_cpio_open does not set grub_errno if a file does not exist.
I can't reproduce this with qemu:
./grub-mkrescue --pkglibdir=`pwd` --grub-mkimage=`pwd`/grub-mkimage --image-type=floppy /tmp/grub-rescue-floppy.img
qemu -fda /tmp/grub-rescue-floppy.img -boot a
is this supposed to be a spurious problem?
> 2008-02-05 Christian Franke <franke@computer.org>
>
> * fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE
> and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last
I would suggest "(and set *ofs = 0)" here to make it clearer.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-02-06 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 23:02 [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection Christian Franke
2008-02-06 0:24 ` Robert Millan [this message]
2008-02-06 8:07 ` Christian Franke
2008-02-06 17:42 ` Christian Franke
2008-02-06 7:29 ` Bean
2008-02-06 19:18 ` Robert Millan
2008-02-06 19:56 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206002439.GC2704@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.