From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection
Date: Wed, 6 Feb 2008 20:18:52 +0100 [thread overview]
Message-ID: <20080206191852.GA7986@thorin> (raw)
In-Reply-To: <ca0f59980802052329y2f336a19ra1cd1ee81a4da9d1@mail.gmail.com>
On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote:
> > This patch fixes both issues.
>
> Actually, the first version of grub_cpio_find_file returned
> GRUB_ERR_FILE_NONE when the end of file is encounter, but then,
> somebody find out that opening non existent file have problem, and the
> result is changed to GRUB_ERR_FILE_NOT_FOUND. I guess it still have
> problem, the fix you are providing seems ok.
Christian doesn't have write perms. Bean, since you're more familiar with
this code, will you check that in?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2008-02-06 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 23:02 [PATCH] Fix crash on open of nonexisting tar/cpio file, fix cpio trailer detection Christian Franke
2008-02-06 0:24 ` Robert Millan
2008-02-06 8:07 ` Christian Franke
2008-02-06 17:42 ` Christian Franke
2008-02-06 7:29 ` Bean
2008-02-06 19:18 ` Robert Millan [this message]
2008-02-06 19:56 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080206191852.GA7986@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.