Re: [git pull] kgdb-light -v10

[Andi Kleen <andi@firstfloor.org>]

On Tue, Feb 12, 2008 at 07:30:15AM -0600, Jason Wessel wrote:
> This is not a technical argument, but I am not a big fan of hard hanging
> the system if you cannot sync all the CPUs. 

Me neither.

> We might be best served to add a comment to explain the purpose of
> kgdb_arch_pc() and put it in the optional implementation function
> headers in include/linux/kgdb.h
> 
> On some archs certain exceptions do not report the address that the
> exception occurred at when you call instruction_pointer(). This optional
> function allows for an arch to perform a "fixup" to get the address the
> exception actually occurred at.

Shouldn't that be handled in the remote gdb?

> 
> Kgdb requires the actual exception address so a sanity check can be
> performed to make sure kgdb did not hit an exception while in a chunk of
> code kgdb requires for its functionality. If you hit one of these

That was for the old longjmp checks, but that code is long gone isn't it
and replacement with standard __ex_table handling.

> conditions kgdb makes its best attempt to try to "patch the wound"
> inflicted by shooting yourself but at least you get notified vs a silent
> hang :-)

In what cases is that still needed?

-Andi