From: Mark Lord <lkml@rtr.ca>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kgdb in git-x86#mm review
Date: Mon, 11 Feb 2008 11:03:38 -0500 [thread overview]
Message-ID: <47B071DA.305@rtr.ca> (raw)
In-Reply-To: <20080211015321.GA27376@one.firstfloor.org>
Andi Kleen wrote:
> ..
> You should probably use simple_strtoul() instead of inventing an
> own hex parser in kgdb.c. And sprintf instead of an own hex writer.
> In general more use sprintf would probably shorten a lot of the parser
> code.
..
Speaking of which.. the kernel implementation of snprintf() seems
to have a bug somewhere, in that it returns an incorrect count in
some situations -- mostly around where the buffer is too small to
hold the data being written. There's an off-by-one bug there somewhere,
but I have not had time yet to track it down more precisely.
Cheers
prev parent reply other threads:[~2008-02-11 16:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 1:53 kgdb in git-x86#mm review Andi Kleen
2008-02-11 15:32 ` Frank Ch. Eigler
2008-02-11 16:11 ` Andi Kleen
2008-02-11 16:21 ` [git pull] kgdb-light -v8, (was: Re: kgdb in git-x86#mm review) Ingo Molnar
2008-02-11 16:41 ` [git pull] kgdb-light -v8, Jan Kiszka
2008-02-11 16:54 ` Ingo Molnar
2008-02-11 17:10 ` [git pull] kgdb-light -v8, (was: Re: kgdb in git-x86#mm review) Andi Kleen
2008-02-11 23:03 ` [git pull] kgdb-light -v9 Ingo Molnar
2008-02-12 10:03 ` Andi Kleen
2008-02-12 9:35 ` Sam Ravnborg
2008-02-12 10:26 ` Roland McGrath
2008-02-12 10:34 ` Ingo Molnar
2008-02-12 11:27 ` [git pull] kgdb-light -v10 Ingo Molnar
2008-02-12 12:19 ` Andi Kleen
2008-02-12 12:38 ` Ingo Molnar
2008-02-12 13:30 ` Jason Wessel
2008-02-12 14:39 ` Andi Kleen
2008-02-12 14:35 ` Jason Wessel
2008-02-12 15:36 ` Andi Kleen
2008-02-12 16:21 ` Jason Wessel
2008-02-12 17:10 ` Andi Kleen
2008-02-12 16:48 ` Jason Wessel
2008-02-12 13:50 ` Andi Kleen
2008-02-12 15:16 ` Ingo Molnar
2008-02-12 15:28 ` Andi Kleen
2008-02-12 15:28 ` Ingo Molnar
2008-02-12 16:11 ` Andi Kleen
2008-02-12 16:24 ` Ingo Molnar
2008-02-12 17:01 ` Andi Kleen
2008-02-12 16:25 ` Linus Torvalds
2008-02-12 16:42 ` Ingo Molnar
2008-02-12 17:07 ` Andi Kleen
2008-02-15 12:35 ` [RFC][PATCH] modular kgdb-light (was: Re: [git pull] kgdb-light -v10) Jan Kiszka
2008-02-15 13:32 ` Andi Kleen
2008-02-15 20:24 ` [RFC][PATCH] modular kgdb-light Jason Wessel
2008-02-15 20:36 ` [git pull] kgdb-light -v10 Jason Wessel
2008-02-12 16:46 ` Linus Torvalds
2008-02-12 17:01 ` Ingo Molnar
2008-02-12 17:10 ` Ingo Molnar
2008-02-12 18:20 ` Andi Kleen
2008-02-12 18:11 ` Linus Torvalds
2008-02-12 19:22 ` Andi Kleen
2008-02-12 19:01 ` Linus Torvalds
2008-02-12 18:20 ` Andrew Morton
2008-02-12 19:16 ` Andi Kleen
2008-02-12 21:01 ` Ingo Molnar
2008-02-12 19:34 ` Frank Ch. Eigler
2008-02-12 20:16 ` Andi Kleen
2008-02-12 13:18 ` Domenico Andreoli
2008-02-12 13:59 ` Jason Wessel
2008-02-12 15:45 ` Domenico Andreoli
2008-02-11 16:03 ` Mark Lord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B071DA.305@rtr.ca \
--to=lkml@rtr.ca \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.