Re: [PATCH] blktap: qcow2 image format support

[Christoph Egger <Christoph.Egger@amd.com>]

On Thursday 21 February 2008 09:57:48 Keir Fraser wrote:
> On 21/2/08 08:49, "Kevin Wolf" <kwolf@suse.de> wrote:
> > This patch adds support for the qcow2 image format to blktap. It
> > consists mostly of qemu code, adapted to the blktap interfaces.
> > Snapshots and compressed images are supported.
> >
> > The qcow2 driver may be used by either specifying tap:qcow2 or by using
> > tap:qcow which will detect that you have a version 2 image and will call
> > the qcow2 driver.
>
> Is qcow2 so different from qcow1 that it really needs its own backend
> driver?

IMO, _all_ blktap drivers need some code refactoring. There is a lot of
duplicated code across all drivers
that can be moved into a blktap/drivers/blk-common.c.

Christoph

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy