From: Kevin Wolf <kwolf@suse.de>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] blktap: qcow2 image format support
Date: Thu, 21 Feb 2008 10:32:09 +0100 [thread overview]
Message-ID: <47BD4519.1030408@suse.de> (raw)
In-Reply-To: <200802211007.14443.Christoph.Egger@amd.com>
Christoph Egger schrieb:
> On Thursday 21 February 2008 09:57:48 Keir Fraser wrote:
> IMO, _all_ blktap drivers need some code refactoring. There is a lot of
> duplicated code across all drivers
> that can be moved into a blktap/drivers/blk-common.c.
Yes, I think you're right on that. I noticed this especially with the
aio function which are duplicated in each single driver. I decided not
to fix this with the qcow2 patch as it is a different problem, but it
could be a good next step.
Kevin
next prev parent reply other threads:[~2008-02-21 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 8:49 [PATCH] blktap: qcow2 image format support Kevin Wolf
2008-02-21 8:57 ` Keir Fraser
2008-02-21 9:07 ` Christoph Egger
2008-02-21 9:32 ` Kevin Wolf [this message]
2008-02-21 12:47 ` Daniel P. Berrange
2008-02-21 17:18 ` Ian Jackson
2008-02-21 9:28 ` Kevin Wolf
2008-02-21 9:20 ` Keir Fraser
2008-02-21 10:31 ` Keir Fraser
2008-02-24 3:12 ` Kurt Hackel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD4519.1030408@suse.de \
--to=kwolf@suse.de \
--cc=Christoph.Egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.