From: "John W. Linville" <linville@tuxdriver.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Julia Lawall <julia@diku.dk>,
yi.zhu@intel.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct
Date: Wed, 27 Feb 2008 00:59:28 +0000 [thread overview]
Message-ID: <20080227005928.GA3066@tuxdriver.com> (raw)
In-Reply-To: <1ba2fa240802261447udd3ff92t20aba416362d5e33@mail.gmail.com>
On Wed, Feb 27, 2008 at 12:47:56AM +0200, Tomas Winkler wrote:
> > diff -u -p a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> > --- a/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-05 20:56:01.000000000 +0100
> > +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-26 08:09:12.000000000 +0100
> > @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(stru
> >
> > if (sta_ht_inf) {
> > if ((!sta_ht_inf->ht_supported) ||
> > - (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
> > + (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
> > return 0;
> > }
>
> The patch was already submitted by Roel Kluin '[PATCH]
> [wireless/iwlwifi/iwl-4965.c] add parentheses' I've acked it.
> Didn't track it if it's actually committed into tree... John, Reinette ?
Already merged and sent to davem...
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Julia Lawall <julia@diku.dk>,
yi.zhu@intel.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and &
Date: Tue, 26 Feb 2008 19:59:28 -0500 [thread overview]
Message-ID: <20080227005928.GA3066@tuxdriver.com> (raw)
In-Reply-To: <1ba2fa240802261447udd3ff92t20aba416362d5e33@mail.gmail.com>
On Wed, Feb 27, 2008 at 12:47:56AM +0200, Tomas Winkler wrote:
> > diff -u -p a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> > --- a/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-05 20:56:01.000000000 +0100
> > +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-26 08:09:12.000000000 +0100
> > @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(stru
> >
> > if (sta_ht_inf) {
> > if ((!sta_ht_inf->ht_supported) ||
> > - (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
> > + (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
> > return 0;
> > }
>
> The patch was already submitted by Roel Kluin '[PATCH]
> [wireless/iwlwifi/iwl-4965.c] add parentheses' I've acked it.
> Didn't track it if it's actually committed into tree... John, Reinette ?
Already merged and sent to davem...
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-02-27 0:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 20:44 [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of Julia Lawall
2008-02-26 20:44 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Julia Lawall
2008-02-26 22:47 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of.and & Tomas Winkler
2008-02-26 22:47 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Tomas Winkler
2008-02-27 0:59 ` John W. Linville [this message]
2008-02-27 0:59 ` John W. Linville
[not found] ` <Pine.LNX.4.64.0802262143570.18200-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2008-03-05 6:38 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Ingo Molnar
2008-03-05 6:38 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Ingo Molnar
2008-03-05 6:38 ` Ingo Molnar
2008-03-05 6:49 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of.and & Christopher Li
2008-03-05 6:49 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Christopher Li
2008-03-05 7:02 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Ingo Molnar
2008-03-05 7:02 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Ingo Molnar
[not found] ` <20080305070201.GA32434-X9Un+BFzKDI@public.gmane.org>
2008-03-05 7:09 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Harvey Harrison
2008-03-05 7:09 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Harvey Harrison
2008-03-05 7:09 ` Harvey Harrison
2008-03-05 8:19 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Ingo Molnar
2008-03-05 8:19 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Ingo Molnar
[not found] ` <20080305081904.GA17789-X9Un+BFzKDI@public.gmane.org>
2008-03-05 12:13 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Derek M Jones
2008-03-05 12:13 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Derek M Jones
2008-03-05 12:13 ` Derek M Jones
2008-03-05 8:55 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Julia Lawall
2008-03-05 8:55 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Julia Lawall
2008-03-05 8:55 ` Julia Lawall
2008-03-05 12:20 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Ingo Molnar
2008-03-05 12:20 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Ingo Molnar
[not found] ` <20080305122010.GA999-X9Un+BFzKDI@public.gmane.org>
2008-03-05 12:30 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of.and & Bart Van Assche
2008-03-05 12:30 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Bart Van Assche
2008-03-05 12:30 ` Bart Van Assche
[not found] ` <e2e108260803050430o317d3e0dyed50e86cc4569746-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-05 12:36 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Ingo Molnar
2008-03-05 12:36 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Ingo Molnar
2008-03-05 12:36 ` Ingo Molnar
2008-03-05 12:35 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct Julia Lawall
2008-03-05 12:35 ` [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & Julia Lawall
2008-03-05 12:35 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227005928.GA3066@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.