All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	linux-mm@kvack.org
Subject: [patch 09/21] (NEW) improve reclaim balancing
Date: Thu, 28 Feb 2008 14:29:17 -0500	[thread overview]
Message-ID: <20080228192928.648701083@redhat.com> (raw)
In-Reply-To: 20080228192908.126720629@redhat.com

[-- Attachment #1: rvr-05-linux-2.6-limit-direct-reclaim.patch --]
[-- Type: text/plain, Size: 1229 bytes --]

- deactivate anonymous pages regardless of the scan ratio
- go through the reclaim loop at least once for the deactivation
- break out of the reclaim loop if we freed sc->swap_cluster_max pages,
  on big systems the nr[FOO] targets can get ridiculously large

Signed-off-by: Rik van Riel <riel@redhat.com>

Index: linux-2.6.25-rc2-mm1/mm/vmscan.c
===================================================================
--- linux-2.6.25-rc2-mm1.orig/mm/vmscan.c	2008-02-28 00:29:40.000000000 -0500
+++ linux-2.6.25-rc2-mm1/mm/vmscan.c	2008-02-28 00:29:46.000000000 -0500
@@ -1302,7 +1302,7 @@ static unsigned long shrink_zone(int pri
 	}
 
 	while (nr[LRU_INACTIVE_ANON] || nr[LRU_ACTIVE_FILE] ||
-						 nr[LRU_INACTIVE_FILE]) {
+					nr[LRU_INACTIVE_FILE]) {
 		for_each_lru(l) {
 			if (nr[l]) {
 				nr_to_scan = min(nr[l],
@@ -1315,6 +1315,14 @@ static unsigned long shrink_zone(int pri
 		}
 	}
 
+	/*
+	 * Even if we did not try to evict anon pages at all, we want to
+	 * rebalance the anon lru active/inactive ratio.
+	 */
+	if (inactive_anon_low(zone))
+		shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
+								priority);
+
 	throttle_vm_writeout(sc->gfp_mask);
 	return nr_reclaimed;
 }

-- 
All Rights Reversed


WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	linux-mm@kvack.org
Subject: [patch 09/21] (NEW) improve reclaim balancing
Date: Thu, 28 Feb 2008 14:29:17 -0500	[thread overview]
Message-ID: <20080228192928.648701083@redhat.com> (raw)
In-Reply-To: 20080228192908.126720629@redhat.com

[-- Attachment #1: rvr-05-linux-2.6-limit-direct-reclaim.patch --]
[-- Type: text/plain, Size: 1454 bytes --]

- deactivate anonymous pages regardless of the scan ratio
- go through the reclaim loop at least once for the deactivation
- break out of the reclaim loop if we freed sc->swap_cluster_max pages,
  on big systems the nr[FOO] targets can get ridiculously large

Signed-off-by: Rik van Riel <riel@redhat.com>

Index: linux-2.6.25-rc2-mm1/mm/vmscan.c
===================================================================
--- linux-2.6.25-rc2-mm1.orig/mm/vmscan.c	2008-02-28 00:29:40.000000000 -0500
+++ linux-2.6.25-rc2-mm1/mm/vmscan.c	2008-02-28 00:29:46.000000000 -0500
@@ -1302,7 +1302,7 @@ static unsigned long shrink_zone(int pri
 	}
 
 	while (nr[LRU_INACTIVE_ANON] || nr[LRU_ACTIVE_FILE] ||
-						 nr[LRU_INACTIVE_FILE]) {
+					nr[LRU_INACTIVE_FILE]) {
 		for_each_lru(l) {
 			if (nr[l]) {
 				nr_to_scan = min(nr[l],
@@ -1315,6 +1315,14 @@ static unsigned long shrink_zone(int pri
 		}
 	}
 
+	/*
+	 * Even if we did not try to evict anon pages at all, we want to
+	 * rebalance the anon lru active/inactive ratio.
+	 */
+	if (inactive_anon_low(zone))
+		shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
+								priority);
+
 	throttle_vm_writeout(sc->gfp_mask);
 	return nr_reclaimed;
 }

-- 
All Rights Reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-02-28 19:45 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 19:29 [patch 00/21] VM pageout scalability improvements Rik van Riel
2008-02-28 19:29 ` Rik van Riel
2008-02-28 19:29 ` [patch 01/21] move isolate_lru_page() to vmscan.c Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-29  2:29   ` KOSAKI Motohiro
2008-02-29  2:29     ` KOSAKI Motohiro
2008-02-29  2:41     ` Rik van Riel
2008-02-29  2:41       ` Rik van Riel
2008-02-29  2:47       ` KOSAKI Motohiro
2008-02-29  2:47         ` KOSAKI Motohiro
2008-02-28 19:29 ` [patch 02/21] Use an indexed array for LRU variables Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-29 16:03   ` Andy Whitcroft
2008-02-29 16:03     ` Andy Whitcroft
2008-03-03 18:57     ` Rik van Riel
2008-03-03 18:57       ` Rik van Riel
2008-02-28 19:29 ` [patch 03/21] use an array for the LRU pagevecs Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-29 15:40   ` Andy Whitcroft
2008-02-29 15:40     ` Andy Whitcroft
2008-03-01  7:02     ` KOSAKI Motohiro
2008-03-01  7:02       ` KOSAKI Motohiro
2008-03-04 11:04       ` KOSAKI Motohiro
2008-03-04 11:04         ` KOSAKI Motohiro
2008-03-04 20:38         ` Rik van Riel
2008-03-04 20:38           ` Rik van Riel
2008-03-05  1:38           ` KOSAKI Motohiro
2008-03-05  1:38             ` KOSAKI Motohiro
2008-02-28 19:29 ` [patch 04/21] free swap space on swap-in/activation Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 20:05   ` Lee Schermerhorn
2008-02-28 20:05     ` Lee Schermerhorn
2008-02-28 20:20     ` Rik van Riel
2008-02-28 20:20       ` Rik van Riel
2008-02-28 19:29 ` [patch 05/21] define page_file_cache() function Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-29 11:53   ` KOSAKI Motohiro
2008-02-29 11:53     ` KOSAKI Motohiro
2008-02-28 19:29 ` [patch 06/21] split LRU lists into anon & file sets Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-03-01 12:13   ` KOSAKI Motohiro
2008-03-01 12:13     ` KOSAKI Motohiro
2008-03-01 12:46   ` KOSAKI Motohiro
2008-03-01 12:46     ` KOSAKI Motohiro
2008-02-28 19:29 ` [patch 07/21] SEQ replacement for anonymous pages Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-03-03 10:50   ` barrioskmc@gmail
2008-03-03 10:50     ` barrioskmc@gmail
2008-02-28 19:29 ` [patch 08/21] (NEW) add some sanity checks to get_scan_ratio Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-03-04 10:40   ` minchan Kim
2008-03-04 10:40     ` minchan Kim
2008-02-28 19:29 ` Rik van Riel [this message]
2008-02-28 19:29   ` [patch 09/21] (NEW) improve reclaim balancing Rik van Riel
2008-03-01 13:35   ` KOSAKI Motohiro
2008-03-01 13:35     ` KOSAKI Motohiro
2008-03-03 19:26     ` Rik van Riel
2008-03-03 19:26       ` Rik van Riel
2008-02-28 19:29 ` [patch 10/21] add newly swapped in pages to the inactive list Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 11/21] (NEW) more aggressively use lumpy reclaim Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-03-02 10:35   ` KOSAKI Motohiro
2008-03-02 10:35     ` KOSAKI Motohiro
2008-03-02 14:23     ` Rik van Riel
2008-03-02 14:23       ` Rik van Riel
2008-02-28 19:29 ` [patch 12/21] No Reclaim LRU Infrastructure Rik van Riel
2008-02-28 19:29   ` Rik van Riel
     [not found]   ` <44c63dc40802282058h67f7597bvb614575f06c62e2c@mail.gmail.com>
2008-02-29 14:48     ` Lee Schermerhorn
2008-02-29 14:48       ` Lee Schermerhorn
     [not found]       ` <44c63dc40803021904n5de681datba400e08079c152d@mail.gmail.com>
2008-03-03  3:06         ` minchan Kim
2008-03-03  3:06           ` minchan Kim
2008-03-03 18:46         ` Rik van Riel
2008-03-03 18:46           ` Rik van Riel
2008-03-03 23:38           ` barrioskmc@gmail
2008-03-03 23:38             ` barrioskmc@gmail
2008-03-04  1:55             ` Rik van Riel
2008-03-04  1:55               ` Rik van Riel
2008-03-04 10:46   ` KOSAKI Motohiro
2008-03-04 10:46     ` KOSAKI Motohiro
2008-03-04 15:05     ` Lee Schermerhorn
2008-03-04 15:05       ` Lee Schermerhorn
2008-03-04 21:21       ` Rik van Riel
2008-03-04 21:21         ` Rik van Riel
2008-03-05  1:42       ` KOSAKI Motohiro
2008-03-05  1:42         ` KOSAKI Motohiro
2008-02-28 19:29 ` [patch 13/21] Non-reclaimable page statistics Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 14/21] scan noreclaim list for reclaimable pages Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 23:41   ` Randy Dunlap
2008-02-28 23:41     ` Randy Dunlap
2008-02-29 14:38     ` Lee Schermerhorn
2008-02-29 14:38       ` Lee Schermerhorn
2008-02-28 19:29 ` [patch 15/21] ramfs pages are non-reclaimable Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 16/21] SHM_LOCKED pages are nonreclaimable Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 17/21] non-reclaimable mlocked pages Rik van Riel
2008-02-28 19:29   ` Rik van Riel
     [not found]   ` <44c63dc40802282055q508af6ccsb0e8ac3fb5e67d24@mail.gmail.com>
2008-02-29 14:47     ` Lee Schermerhorn
2008-02-29 14:47       ` Lee Schermerhorn
2008-02-28 19:29 ` [patch 18/21] mlock vma pages under mmap_sem held for read Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 19/21] handle mlocked pages during map/unmap and truncate Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 20/21] account mlocked pages Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 19:29 ` [patch 21/21] cull non-reclaimable anon pages from the LRU at fault time Rik van Riel
2008-02-28 19:29   ` Rik van Riel
2008-02-28 20:19   ` Lee Schermerhorn
2008-02-28 20:19     ` Lee Schermerhorn
2008-02-28 22:27     ` Rik van Riel
2008-02-28 22:27       ` Rik van Riel
2008-02-28 19:49 ` [patch 00/21] VM pageout scalability improvements Rik van Riel
2008-02-28 19:49   ` Rik van Riel
2008-02-28 20:14 ` John Stoffel
2008-02-28 20:14   ` John Stoffel
2008-02-28 20:23   ` Rik van Riel
2008-02-28 20:23     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228192928.648701083@redhat.com \
    --to=riel@redhat.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.