From: Theodore Tso <tytso@MIT.EDU>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Matthias Koenig <mkoenig@suse.de>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes
Date: Fri, 14 Mar 2008 10:40:21 -0400 [thread overview]
Message-ID: <20080314144021.GE7412@mit.edu> (raw)
In-Reply-To: <47DA87EF.6040405@redhat.com>
On Fri, Mar 14, 2008 at 09:13:03AM -0500, Eric Sandeen wrote:
> Yep, there were 2 problems.
>
> One was that inode_scan_and_fix() wasn't moving all of large inodes.
>
> The other was that ext2fs_swap_inode_full was doing bad things for
> in-inode attrs on big endian boxes, that was the patch in this thread
> which isn't in the repo yet, but is in fact needed.
>
> I suppose that the iterative nature of my fix for this problem didn't
> help Ted keep things straight, sorry.
I actually *prefer* multiple patches, actually, but what works best
when there is a series of patches is to resend the whole patch stack
using git-format-patch or git-send-email --- or set up your own git
repository on the network (or use repo.or.cz) and send me a pull
request. But that requires much more use of git. :-)
In any case, I'll pull in the last change, and this time I promise
I'll be careful about remembering to use --author. That *is*
something I should be doing, but I certainly appreciate people using
git's facilities to make my life easier, thanks.
- Ted
next prev parent reply other threads:[~2008-03-14 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 22:10 [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes Eric Sandeen
2008-03-14 13:09 ` Matthias Koenig
2008-03-14 13:32 ` Theodore Tso
2008-03-14 14:13 ` Eric Sandeen
2008-03-14 14:40 ` Theodore Tso [this message]
2008-03-14 17:14 ` Theodore Tso
2008-03-14 17:42 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314144021.GE7412@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=mkoenig@suse.de \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.