Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:
> On Fri, Feb 29, 2008 at 04:10:21PM -0600, Eric Sandeen wrote:
>> +
>> +	if (hostorder)
>> +		attr_magic = *eaf;
>>  	*eat = ext2fs_swab32(*eaf);
>> +	if (!hostorder)
>> +		attr_magic = *eat;
>> +
>> +	if (attr_magic != EXT2_EXT_ATTR_MAGIC)
>> +		return; /* it seems no magic here */
> 
> The problem with this is that if the magic isn't there, we still end
> up writing 4 bytes into the destination.  So I think this is a better
> patch....
> 

Seems good to me.

Thanks,
-Eric