Re: [PATCH] e2fsprogs- fix ext2fs_swap_inode_full attr test on BE boxes

[Eric Sandeen <sandeen@redhat.com>]

Theodore Tso wrote:

> This patch is in the repo, which I thought superceded the one which
> Eric sent.  (The authorship is wrong; and that was my fault for not
> including '--author="Eric Sandeen <sandeen@redhat.com>"' on the commit
> command-line.  I've already apologized to Eric privately; now I'm
> apologizing publically.  :-)

And I've realized that I really should start using git to make it easier
on Ted.  :)

> But looking at it again, I believe I misunderstood, and the two
> patches are attacking quite separate problems.  OK, i'll get this one
> in as well in the next go-around.

Yep, there were 2 problems.

One was that inode_scan_and_fix() wasn't moving all of large inodes.

The other was that ext2fs_swap_inode_full was doing bad things for
in-inode attrs on big endian boxes, that was the patch in this thread
which isn't in the repo yet, but is in fact needed.

I suppose that the iterative nature of my fix for this problem didn't
help Ted keep things straight, sorry.

-Eric