Re: [PATCH] I2C: ISP1301: Sync with linux-omap

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Tue, 18 Mar 2008 15:09:43 +0200, Felipe Balbi wrote:
> On Tue, Mar 18, 2008 at 2:46 PM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> > Hi Felipe,
> >
> >
> >  On Sun, 16 Mar 2008 13:00:35 +0200, Felipe Balbi wrote:
> >  > There are some changes on linux-omap's isp1301_omap.c
> >  > that could already be in linux-mainline after
> >  > omap1/2 got merged.
> >  >
> >  > This patch sync such changes from linux-omap into linux-mailine.
> >
> >  I fear I will need a better description than this. Please explain what
> >  the changes are and why they are needed. "sync with an external tree"
> >  isn't sufficient.
> 
> Here's a better description:
> 
> Now that omap1/2 were merged on mainline we can bring the isp1301_omap.c
> changes that were done for board-h3 and keep the code in sync. This will allow
> us to decrese the diff between linux-omap and mainline and avoid merge conflicts
> later.
> 
> 
> Is this good enough ?

No. You are just paraphrasing, this doesn't help. I need an explanation
of the _functional_ changes implemented by the patch. I don't care much
that these changes come from the omap tree, I don't know anything about
this tree. What I need to know is why the changes are needed by
themselves. What problem(s) does this patch address?

> I can think in something else if you need a better description ;-)

Thanks,
-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c