All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Felipe Balbi
	<felipebalbi-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] I2C: ISP1301: Sync with linux-omap
Date: Thu, 20 Mar 2008 02:39:47 -0700	[thread overview]
Message-ID: <200803200239.47880.david-b@pacbell.net> (raw)
In-Reply-To: <31e679430803180628h7a4926a2t4e540d9617522e28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tuesday 18 March 2008, Felipe Balbi wrote:
> >
> >  No. You are just paraphrasing, this doesn't help. I need an explanation
> >  of the _functional_ changes implemented by the patch. I don't care much
> >  that these changes come from the omap tree, I don't know anything about
> >  this tree. What I need to know is why the changes are needed by
> >  themselves. What problem(s) does this patch address?
> 
> otherwise the driver won't work on board-h3, simple enough

But the reason those changes were never pushed upstream is that
they were known to break board-h2 !!

I was never keen on merging them into the OMAP tree in the first
place, specifically for that reason ... the original idea was
to merge patches that worked on *both* chip revisions.  Failing
that, to follow up the H3 patches with bugfixes; those fixes
never got submitted.

So for what it's worth, I'll NAK those state machine updates.
On the grounds that they *add* bugs.  H3 doesn't work in the
mainline tree yet, so there's no way such a patch could ever
be viewed as an improving anything whatsoever for mainline.





_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-03-20  9:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-15 12:47 [PATH 0/3] isp1301 changes Felipe Balbi
     [not found] ` <1205585237-21492-1-git-send-email-me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-03-15 12:47   ` [PATCH] I2C: Introduce irq_flags in i2c_boardinfo and i2c_client Felipe Balbi
     [not found]     ` <1205585237-21492-2-git-send-email-me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-03-15 12:47       ` [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 1 Felipe Balbi
     [not found]         ` <1205585237-21492-3-git-send-email-me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-03-15 12:47           ` [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2 Felipe Balbi
     [not found]             ` <1205585237-21492-4-git-send-email-me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
2008-03-15 12:49               ` Felipe Balbi
     [not found]                 ` <20080315124918.GA21547-4vvIQG7NF+ITKvXZea5imILpUPVTGn5w@public.gmane.org>
2008-03-15 12:54                   ` Felipe Balbi
     [not found]                     ` <20080315125458.GB21547-4vvIQG7NF+ITKvXZea5imILpUPVTGn5w@public.gmane.org>
2008-03-15 13:13                       ` Felipe Balbi
     [not found]                         ` <20080315131309.GA24990-4vvIQG7NF+ITKvXZea5imILpUPVTGn5w@public.gmane.org>
2008-03-16 10:56                           ` Felipe Balbi
     [not found]                             ` <20080316105617.GA4503-4vvIQG7NF+ITKvXZea5imILpUPVTGn5w@public.gmane.org>
2008-03-16 11:00                               ` [PATCH] I2C: ISP1301: Sync with linux-omap Felipe Balbi
     [not found]                                 ` <20080316110033.GB4503-4vvIQG7NF+ITKvXZea5imILpUPVTGn5w@public.gmane.org>
2008-03-16 17:59                                   ` David Brownell
     [not found]                                     ` <200803161059.52278.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-03-16 18:18                                       ` Felipe Balbi
2008-03-18 12:46                                   ` Jean Delvare
     [not found]                                     ` <20080318134633.16f6e5f1-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-18 13:09                                       ` Felipe Balbi
     [not found]                                         ` <31e679430803180609s2b404dabu1cac2e09f128ba96-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-18 13:23                                           ` Jean Delvare
     [not found]                                             ` <20080318142337.0f9a2b5b-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-18 13:28                                               ` Felipe Balbi
     [not found]                                                 ` <31e679430803180628h7a4926a2t4e540d9617522e28-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-20  9:39                                                   ` David Brownell [this message]
2008-03-16 17:55                               ` [PATCH] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2 David Brownell
2008-03-18 12:42                               ` Jean Delvare
     [not found]                                 ` <20080318134259.1b7e2878-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-18 13:06                                   ` Felipe Balbi
     [not found]                                     ` <31e679430803180606w51e5538ar1df7fbdfa5a0e894-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-18 13:27                                       ` Jean Delvare
     [not found]                                         ` <20080318142716.74d65ba1-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-20  9:44                                           ` David Brownell
2008-03-18 13:15                               ` Jean Delvare
     [not found]                                 ` <20080318141528.53f4b2d8-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-18 13:25                                   ` Felipe Balbi
2008-03-20  9:56                               ` David Brownell
2008-03-31 17:37                               ` Ben Dooks
     [not found]                                 ` <20080331173749.GA10234-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2008-03-31 18:41                                   ` Jean Delvare
2008-03-15 15:28   ` [PATH 0/3] isp1301 changes Jean Delvare
     [not found]     ` <20080315162832.067b8088-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-15 15:38       ` Felipe Balbi
     [not found]         ` <31e679430803150838n6638be05k53800bb74eeb3462-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-15 15:40           ` Felipe Balbi
     [not found]             ` <31e679430803150840p334e8d17ncdd1fdc431de8d82-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-03-15 16:47               ` Jean Delvare
     [not found]                 ` <20080315174731.29cfb554-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-03-15 23:22                   ` Felipe Balbi
2008-03-16  3:57               ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803200239.47880.david-b@pacbell.net \
    --to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
    --cc=felipebalbi-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.