From: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, galak@kernel.crashing.org,
linuxppc-dev@ozlabs.org, Andy Whitcroft <apw@shadowen.org>,
yorksun@freescale.com
Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD
Date: Thu, 20 Mar 2008 15:33:04 -0700 [thread overview]
Message-ID: <20080320153304.cdc1817d.akpm@linux-foundation.org> (raw)
In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com>
On Wed, 19 Mar 2008 13:50:27 -0500
York Sun <yorksun@freescale.com> wrote:
> Add platform code to support Freescale DIU. The platform code includes
> framebuffer memory allocation, pixel format, monitor port, etc.
>
> ...
>
> +unsigned int mpc8610hpcd_get_pixel_format
> + (unsigned int bits_per_pixel, int monitor_port)
Again, please do
unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel,
int monitor_port)
(and anywhere else where this was done)
> +int __init preallocate_diu_videomemory(void);
Nope, please don't put extern declarations in .c files. Find a suitable
header for it - one which is included by the defining file and by all users
of the symbol.
Andy, checkpatch missed this.
> }
> #endif
> +
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: York Sun <yorksun@freescale.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
yorksun@freescale.com
Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD
Date: Thu, 20 Mar 2008 15:33:04 -0700 [thread overview]
Message-ID: <20080320153304.cdc1817d.akpm@linux-foundation.org> (raw)
In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com>
On Wed, 19 Mar 2008 13:50:27 -0500
York Sun <yorksun@freescale.com> wrote:
> Add platform code to support Freescale DIU. The platform code includes
> framebuffer memory allocation, pixel format, monitor port, etc.
>
> ...
>
> +unsigned int mpc8610hpcd_get_pixel_format
> + (unsigned int bits_per_pixel, int monitor_port)
Again, please do
unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel,
int monitor_port)
(and anywhere else where this was done)
> +int __init preallocate_diu_videomemory(void);
Nope, please don't put extern declarations in .c files. Find a suitable
header for it - one which is included by the defining file and by all users
of the symbol.
Andy, checkpatch missed this.
> }
> #endif
> +
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: York Sun <yorksun@freescale.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
galak@kernel.crashing.org,
linux-fbdev-devel@lists.sourceforge.net, yorksun@freescale.com,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD
Date: Thu, 20 Mar 2008 15:33:04 -0700 [thread overview]
Message-ID: <20080320153304.cdc1817d.akpm@linux-foundation.org> (raw)
In-Reply-To: <12059526271964-git-send-email-yorksun@freescale.com>
On Wed, 19 Mar 2008 13:50:27 -0500
York Sun <yorksun@freescale.com> wrote:
> Add platform code to support Freescale DIU. The platform code includes
> framebuffer memory allocation, pixel format, monitor port, etc.
>
> ...
>
> +unsigned int mpc8610hpcd_get_pixel_format
> + (unsigned int bits_per_pixel, int monitor_port)
Again, please do
unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel,
int monitor_port)
(and anywhere else where this was done)
> +int __init preallocate_diu_videomemory(void);
Nope, please don't put extern declarations in .c files. Find a suitable
header for it - one which is included by the defining file and by all users
of the symbol.
Andy, checkpatch missed this.
> }
> #endif
> +
next prev parent reply other threads:[~2008-03-20 22:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 18:50 v2 patch for Freescale DIU driver York Sun
2008-03-19 18:50 ` York Sun
2008-03-19 18:50 ` [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU York Sun
2008-03-19 18:50 ` York Sun
2008-03-19 18:50 ` [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD York Sun
2008-03-19 18:50 ` York Sun
2008-03-20 22:33 ` Andrew Morton [this message]
2008-03-20 22:33 ` Andrew Morton
2008-03-20 22:33 ` Andrew Morton
2008-03-25 12:43 ` Andy Whitcroft
2008-03-25 12:43 ` Andy Whitcroft
2008-03-25 19:18 ` Andrew Morton
2008-03-25 19:18 ` Andrew Morton
2008-03-25 19:18 ` Andrew Morton
2008-03-20 22:27 ` [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU Andrew Morton
2008-03-20 22:27 ` Andrew Morton
2008-03-20 22:27 ` Andrew Morton
2008-03-20 23:02 ` Peter Zijlstra
2008-03-20 23:02 ` Peter Zijlstra
2008-03-21 16:12 ` Timur Tabi
2008-03-21 16:12 ` Timur Tabi
2008-03-21 18:12 ` Andrew Morton
2008-03-21 18:12 ` Andrew Morton
2008-03-21 18:12 ` Andrew Morton
2008-03-24 14:53 ` Timur Tabi
2008-03-24 14:53 ` Timur Tabi
2008-03-24 14:53 ` Timur Tabi
2008-03-24 18:47 ` Andrew Morton
2008-03-24 18:47 ` Andrew Morton
2008-03-24 18:47 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320153304.cdc1817d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=galak@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.