All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dean Nelson <dcn@sgi.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, jes@sgi.com,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org
Subject: Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl
Date: Wed, 26 Mar 2008 16:58:39 +0000	[thread overview]
Message-ID: <20080326165839.GG20663@sgi.com> (raw)
In-Reply-To: <20080326100336.GE22584@shadowen.org>

On Wed, Mar 26, 2008 at 10:03:36AM +0000, Andy Whitcroft wrote:
> On Tue, Mar 25, 2008 at 03:05:17PM -0500, Dean Nelson wrote:
> 
> Gah, who ever came up with that syntax.  Yep, thats a falsie.  Should be
> fixed in the latest version:
> 
>   http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-next
> 
> Thanks for the report.

You're welcome and thanks for the quick fix to checkpatch.pl.
I used the new version and it fixed the problem except for ones that were of
the following form:

enum xp_retval (*xp_set_amo_with_interrupt) (u64 *amo_va, int op, u64 operand,
                                             int remote, int nasid,
                                             int phys_cpuid, int vector);
EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

which still generated the false positive:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#70: FILE: misc/xp/xp_main.c:70:
+EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

Thanks,
Dean

WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dcn@sgi.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com, jes@sgi.com,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org
Subject: Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl
Date: Wed, 26 Mar 2008 11:58:39 -0500	[thread overview]
Message-ID: <20080326165839.GG20663@sgi.com> (raw)
In-Reply-To: <20080326100336.GE22584@shadowen.org>

On Wed, Mar 26, 2008 at 10:03:36AM +0000, Andy Whitcroft wrote:
> On Tue, Mar 25, 2008 at 03:05:17PM -0500, Dean Nelson wrote:
> 
> Gah, who ever came up with that syntax.  Yep, thats a falsie.  Should be
> fixed in the latest version:
> 
>   http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-next
> 
> Thanks for the report.

You're welcome and thanks for the quick fix to checkpatch.pl.
I used the new version and it fixed the problem except for ones that were of
the following form:

enum xp_retval (*xp_set_amo_with_interrupt) (u64 *amo_va, int op, u64 operand,
                                             int remote, int nasid,
                                             int phys_cpuid, int vector);
EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

which still generated the false positive:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#70: FILE: misc/xp/xp_main.c:70:
+EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

Thanks,
Dean

  reply	other threads:[~2008-03-26 16:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-25 19:25 [Patch 0/5] prepare XPC and XPNET to support SGI UV dcn
2008-03-25 19:25 ` dcn
2008-03-25 19:25 ` [Patch 1/5] add multi-page allocation to the uncached allocator dcn
2008-03-25 19:25   ` dcn
2008-03-25 19:25 ` [Patch 3/5] prepare XPC and XPNET for future support of SGIs UV architecture dcn
2008-03-25 19:25 ` [Patch 4/5] run drivers/misc/xp through scripts/Lindent dcn
2008-03-25 19:25 ` [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl dcn
2008-03-25 19:25   ` dcn
2008-03-25 20:05   ` Dean Nelson
2008-03-25 20:05     ` Dean Nelson
2008-03-26 10:03     ` Andy Whitcroft
2008-03-26 16:58       ` Dean Nelson [this message]
2008-03-26 16:58         ` Dean Nelson
2008-03-25 20:14 ` [Patch 0/5] prepare XPC and XPNET to support SGI UV Dean Nelson
2008-03-25 20:14   ` Dean Nelson
2008-03-25 22:49   ` Luck, Tony
2008-03-25 22:49     ` Luck, Tony
2008-03-25 23:04     ` Andreas Schwab
2008-03-25 23:04       ` Andreas Schwab
2008-03-26 16:38 ` [Patch 0/5] prepare XPC and XPNET to support SGI UV -v2 Dean Nelson
2008-03-26 16:38   ` Dean Nelson
2008-03-26 16:48   ` [Patch 1/5] add multi-page allocation to the uncached allocator -v2 Dean Nelson
2008-03-26 16:48     ` Dean Nelson
2008-03-26 16:50   ` [Patch 2/5] move XP and XPC to drivers/misc/xp -v2 Dean Nelson
2008-03-26 16:50     ` Dean Nelson
2008-03-26 16:51   ` [Patch 3/5] prepare XPC and XPNET for future support of SGIs UV architecture -v2 Dean Nelson
2008-03-26 16:52   ` [Patch 4/5] run drivers/misc/xp through scripts/Lindent -v2 Dean Nelson
2008-03-26 16:53   ` [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl -v2 Dean Nelson
2008-03-26 16:53     ` Dean Nelson
2008-03-26 21:58 ` [Patch 0/5] prepare XPC and XPNET to support SGI UV -v3 Dean Nelson
2008-03-26 21:58   ` Dean Nelson
2008-03-26 22:00   ` [Patch 1/5] add multi-page allocation to the uncached allocator -v3 Dean Nelson
2008-03-26 22:00     ` Dean Nelson
2008-03-26 22:02   ` [Patch 2/5] move XP and XPC to drivers/misc/xp -v3 Dean Nelson
2008-03-26 22:02     ` Dean Nelson
2008-03-26 22:03   ` [Patch 3/5] prepare XPC and XPNET for future support of SGIs UV architecture -v3 Dean Nelson
2008-03-26 22:04   ` [Patch 4/5] run drivers/misc/xp through scripts/Lindent -v3 Dean Nelson
2008-03-26 22:05   ` [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl -v3 Dean Nelson
2008-03-26 22:05     ` Dean Nelson
2008-03-26 22:25   ` [Patch 0/5] prepare XPC and XPNET to support SGI UV -v3 Dean Nelson
2008-03-26 22:25     ` Dean Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326165839.GG20663@sgi.com \
    --to=dcn@sgi.com \
    --cc=apw@shadowen.org \
    --cc=jes@sgi.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.