From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 3/3] ppc4xx: Change Canyonlands to support booting from 2k page NAND devices
Date: Tue, 8 Apr 2008 13:52:01 +0200 [thread overview]
Message-ID: <200804081352.01473.sr@denx.de> (raw)
In-Reply-To: <20080408114737.2AE3424842@gemini.denx.de>
On Tuesday 08 April 2008, Wolfgang Denk wrote:
> > diff --git a/board/amcc/canyonlands/bootstrap.c
> > b/board/amcc/canyonlands/bootstrap.c index 37fa1c9..1d125b6 100644
> > --- a/board/amcc/canyonlands/bootstrap.c
> > +++ b/board/amcc/canyonlands/bootstrap.c
> > @@ -63,9 +63,22 @@ static u8 boot_configs[][17] = {
> > /*
> > * Bytes 5,6,8,9,11 change for NAND boot
> > */
> > +#if 0
> > +/*
> > + * Values for 512 page size NAND chips, not used anymore, just
> > + * keep them here for reference
> > + */
>
> Please don't add dead code.
I was unsure about this, and kept it in as a reference for 460EX/GT boards
using 512 page size NAND chips (see comment above). Such a reference is quite
valuable from my point of view.
How should I keep such code available?
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-04-08 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 8:33 [U-Boot-Users] [PATCH 1/3] ppc4xx: Add Glacier NAND booting target Stefan Roese
2008-04-08 8:33 ` [U-Boot-Users] [PATCH 2/3] ppc4xx: Adjust Canyonlands fixed DDR2 setup (NAND booting) to 512MB SODIMM Stefan Roese
2008-04-08 8:33 ` [U-Boot-Users] [PATCH 3/3] ppc4xx: Change Canyonlands to support booting from 2k page NAND devices Stefan Roese
2008-04-08 11:47 ` Wolfgang Denk
2008-04-08 11:52 ` Stefan Roese [this message]
2008-04-08 12:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804081352.01473.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.