[uml-devel] [Patch] uml: compile error fix

[uml-devel] [Patch] uml: compile error fix

[WANG Cong]

[-- Attachment #1: Type: Text/Plain, Size: 929 bytes --]


This patch fixes this error:

  CC      arch/um/kernel/smp.o
In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
include2/asm/tlb.h: In function ‘tlb_remove_page’:
include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’
make[2]: *** [arch/um/kernel/smp.o] Error 1
make[1]: *** [arch/um/kernel] Error 2
make: *** [sub-make] Error 2

And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
we add this #include in uml's own header.

Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: WANG Cong <wangcong@zeuux.org>

---
diff --git a/include/asm-um/tlb.h b/include/asm-um/tlb.h
index 39fc475..5240fa1 100644
--- a/include/asm-um/tlb.h
+++ b/include/asm-um/tlb.h
@@ -1,6 +1,7 @@
 #ifndef __UM_TLB_H
 #define __UM_TLB_H
 
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 #include <asm/percpu.h>
 #include <asm/pgalloc.h>

[-- Attachment #2: Type: text/plain, Size: 320 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

[-- Attachment #3: Type: text/plain, Size: 194 bytes --]

_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

[Patch] uml: compile error fix

[WANG Cong]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=gb2312, Size: 1059 bytes --]


This patch fixes this error:

  CC      arch/um/kernel/smp.o
In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
include2/asm/tlb.h: In function ¡®tlb_remove_page¡¯:
include2/asm/tlb.h:101: error: implicit declaration of function ¡®page_cache_release¡¯
make[2]: *** [arch/um/kernel/smp.o] Error 1
make[1]: *** [arch/um/kernel] Error 2
make: *** [sub-make] Error 2

And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
we add this #include in uml's own header.

Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: WANG Cong <wangcong@zeuux.org>

---
diff --git a/include/asm-um/tlb.h b/include/asm-um/tlb.h
index 39fc475..5240fa1 100644
--- a/include/asm-um/tlb.h
+++ b/include/asm-um/tlb.h
@@ -1,6 +1,7 @@
 #ifndef __UM_TLB_H
 #define __UM_TLB_H
 
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 #include <asm/percpu.h>
 #include <asm/pgalloc.h>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [uml-devel] [Patch] uml: compile error fix

[Jeff Dike]

On Sat, Apr 12, 2008 at 05:47:33PM +0800, WANG Cong wrote:
> 
> This patch fixes this error:
> 
>   CC      arch/um/kernel/smp.o
> In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
> include2/asm/tlb.h: In function ‘tlb_remove_page’:
> include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’
> make[2]: *** [arch/um/kernel/smp.o] Error 1
> make[1]: *** [arch/um/kernel] Error 2
> make: *** [sub-make] Error 2
> 
> And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
> we add this #include in uml's own header.

Sigh, ACK.

I took a stab at fixing this problem for real a while ago by
untangling the headers involved, but failed.

	       	       		 Jeff

-- 
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [Patch] uml: compile error fix

[Jeff Dike]

On Sat, Apr 12, 2008 at 05:47:33PM +0800, WANG Cong wrote:
> 
> This patch fixes this error:
> 
>   CC      arch/um/kernel/smp.o
> In file included from /home/wangcong/projects/linux-2.6/arch/um/kernel/smp.c:9:
> include2/asm/tlb.h: In function ‘tlb_remove_page’:
> include2/asm/tlb.h:101: error: implicit declaration of function ‘page_cache_release’
> make[2]: *** [arch/um/kernel/smp.o] Error 1
> make[1]: *** [arch/um/kernel] Error 2
> make: *** [sub-make] Error 2
> 
> And since including <linux/pagemap.h> in <linux/swap.h> will break sparc,
> we add this #include in uml's own header.

Sigh, ACK.

I took a stab at fixing this problem for real a while ago by
untangling the headers involved, but failed.

	       	       		 Jeff

-- 
Work email - jdike at linux dot intel dot com