From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org,
joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
Date: Wed, 30 Apr 2008 15:55:33 -0700 [thread overview]
Message-ID: <200804301555.34110.david-b@pacbell.net> (raw)
In-Reply-To: <20080430154631.b86797de.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
On Wednesday 30 April 2008, Andrew Morton wrote:
> > + spin_lock_irq(&mpc83xx_spi->lock);
>
> irq-safe.
>
> > ...
> >
> > + spin_lock(&mpc83xx_spi->lock);
>
> not irq-safe.
>
> Deliberate?
That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me. Maybe Joakim can remove it.
(By the way, I'd feel safer about this patch if there were an
ack or two from more PPC folk...)
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: spi-devel-general@lists.sourceforge.net, 12o3l@tiscali.nl,
linuxppc-dev@ozlabs.org
Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
Date: Wed, 30 Apr 2008 15:55:33 -0700 [thread overview]
Message-ID: <200804301555.34110.david-b@pacbell.net> (raw)
In-Reply-To: <20080430154631.b86797de.akpm@linux-foundation.org>
On Wednesday 30 April 2008, Andrew Morton wrote:
> > + spin_lock_irq(&mpc83xx_spi->lock);
>
> irq-safe.
>
> > ...
> >
> > + spin_lock(&mpc83xx_spi->lock);
>
> not irq-safe.
>
> Deliberate?
That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me. Maybe Joakim can remove it.
(By the way, I'd feel safer about this patch if there were an
ack or two from more PPC folk...)
next prev parent reply other threads:[~2008-04-30 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:37 [patch 2.6.25-git] spi_mpc83xx much improved driver David Brownell
2008-04-30 22:37 ` David Brownell
[not found] ` <200804301537.07965.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-04-30 22:46 ` Andrew Morton
2008-04-30 22:46 ` Andrew Morton
[not found] ` <20080430154631.b86797de.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-04-30 22:55 ` David Brownell [this message]
2008-04-30 22:55 ` David Brownell
2008-05-01 10:42 ` Joakim Tjernlund
[not found] ` <200804301555.34110.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-05-01 10:42 ` Joakim Tjernlund
2008-05-01 10:42 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804301555.34110.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.