All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] input: JOYSTICK_XPAD build fix
Date: Wed, 30 Apr 2008 22:03:40 +0200	[thread overview]
Message-ID: <20080430200340.GA13757@elte.hu> (raw)

x86.git testing found the following build failure in -git:

 ERROR: "led_classdev_register" [drivers/input/joystick/xpad.ko] undefined!
 ERROR: "led_classdev_unregister" [drivers/input/joystick/xpad.ko] undefined!

which triggers with the following config:

 http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad

the reason is dependency on NEW_LEDS that was not spelled out in the
Kconfig entry of JOYSTICK_XPAD.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/input/joystick/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/input/joystick/Kconfig
===================================================================
--- linux.orig/drivers/input/joystick/Kconfig
+++ linux/drivers/input/joystick/Kconfig
@@ -268,6 +268,7 @@ config JOYSTICK_JOYDUMP
 config JOYSTICK_XPAD
 	tristate "X-Box gamepad support"
 	depends on USB_ARCH_HAS_HCD
+	depends on NEW_LEDS
 	select USB
 	help
 	  Say Y here if you want to use the X-Box pad with your computer.

             reply	other threads:[~2008-04-30 20:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 20:03 Ingo Molnar [this message]
2008-04-30 21:02 ` [patch] input: JOYSTICK_XPAD build fix Dmitry Torokhov
2008-04-30 21:13   ` Ingo Molnar
2008-04-30 23:01     ` Ingo, no more kconfig patches Adrian Bunk
2008-05-01  1:17       ` Ingo Molnar
2008-05-01  1:37         ` Adrian Bunk
2008-05-01  2:06           ` Ingo Molnar
2008-05-01  2:12             ` Adrian Bunk
2008-05-01  2:52       ` Ingo Molnar
2008-05-01 11:59         ` Adrian Bunk
2008-05-03 19:14           ` Ingo Molnar
2008-05-03 19:17             ` Ingo Molnar
2008-05-03 20:24             ` Adrian Bunk
2008-05-03 21:03               ` Ingo Molnar
2008-05-03 21:24                 ` Adrian Bunk
2008-05-03 21:38                   ` Sam Ravnborg
2008-05-03 22:07                     ` Adrian Bunk
2008-05-04  7:36                       ` Sam Ravnborg
2008-05-04  7:49                         ` Adrian Bunk
2008-05-03 21:52                   ` Ingo Molnar
2008-05-03 22:03                     ` Adrian Bunk
2008-05-04  3:54                       ` Valdis.Kletnieks
2008-05-04  7:47                         ` Adrian Bunk
2008-05-03 23:22                   ` Thomas Gleixner
2008-05-04  0:34                     ` Adrian Bunk
2008-05-03 21:17               ` Krzysztof Halasa
2008-05-03 21:47                 ` Adrian Bunk
2008-05-03 22:13                   ` Krzysztof Halasa
2008-05-03 22:29                     ` Adrian Bunk
2008-05-03 23:37                       ` Krzysztof Halasa
2008-05-04  0:49                         ` Adrian Bunk
2008-05-04 12:18                           ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080430200340.GA13757@elte.hu \
    --to=mingo@elte.hu \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.